This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: make doctest on 3.10 (master branch) fails with setuptools 50.0.0
Type: Stage: resolved
Components: Documentation Versions: Python 3.10
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: ammar2, docs@python, mdk, ned.deily, vstinner, xtreak
Priority: high Keywords: patch

Created on 2020-09-01 09:38 by ned.deily, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 22038 merged ned.deily, 2020-09-01 09:39
PR 22062 merged vstinner, 2020-09-02 10:33
Messages (7)
msg376184 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2020-09-01 09:38
See pypa/setuptools#2361 for details.

For now, temporarily pin setuptools version in the Doc venv to a previous version.

Victor notes:
""Temporarily pin setuptools": we already pin Sphinx version to also avoid breaking the CI when a new Sphinx version is released. It would make sense to make our CI less dependent on releases of third party components: better control when we update dependencies. The risk is to forget to update these dependences if the updates are not automated."
msg376185 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2020-09-01 09:40
New changeset a4c4e17f959621ab00a98086af1704fb0c896466 by Ned Deily in branch 'master':
bpo-41685: Temporarily pin setuptools to 49.2.1 in Docs venv. (GH-22038)
https://github.com/python/cpython/commit/a4c4e17f959621ab00a98086af1704fb0c896466
msg376186 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-09-01 09:44
I proposed https://github.com/pypa/setuptools/pull/2361 to fix setuptools compatibility with Python 3.10.
msg376214 - (view) Author: Ammar Askar (ammar2) * (Python committer) Date: 2020-09-02 02:34
Victor's fix is now in the 50.0.2 release, should we bump the pinned version, remove its pinning or do nothing?

https://github.com/pypa/setuptools/commit/edcf84faaf17e87e6e38796dd24f66d9236bf87c

https://pypi.org/project/setuptools/#history
msg376224 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-09-02 10:34
I proposed PR 22062 to unpin the setuptools version.

Unless someone steps in and proposes a solution to automate updating the pinned setuptools version, I prefer to not pin the version.
msg376226 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-09-02 11:11
New changeset 51fece1bb8d7aa22f114172a256714fe24788e31 by Victor Stinner in branch 'master':
bpo-41685: Don't pin setuptools version anymore in Doc/Makefile (GH-22062)
https://github.com/python/cpython/commit/51fece1bb8d7aa22f114172a256714fe24788e31
msg376227 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-09-02 11:11
As far as I know, the issue is fixed, so I close the issue.

Thanks Ned for the temporary fix to repair the workflow!
History
Date User Action Args
2022-04-11 14:59:35adminsetgithub: 85851
2020-09-02 11:11:55vstinnersetstatus: open -> closed
resolution: fixed
messages: + msg376227

stage: patch review -> resolved
2020-09-02 11:11:24vstinnersetmessages: + msg376226
2020-09-02 10:34:31vstinnersetmessages: + msg376224
2020-09-02 10:33:42vstinnersetstage: needs patch -> patch review
pull_requests: + pull_request21152
2020-09-02 02:34:35ammar2setnosy: + ammar2
messages: + msg376214
2020-09-01 09:56:25xtreaksetnosy: + xtreak
2020-09-01 09:56:15xtreaklinkissue41674 superseder
2020-09-01 09:44:33vstinnersetmessages: + msg376186
2020-09-01 09:41:04ned.deilysetpriority: critical -> high
stage: patch review -> needs patch
2020-09-01 09:40:44ned.deilysetmessages: + msg376185
2020-09-01 09:39:27ned.deilysetkeywords: + patch
stage: commit review -> patch review
pull_requests: + pull_request21135
2020-09-01 09:38:54ned.deilycreate