➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2020-06-04 19:11 by erlendaasland, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 20627 | merged | erlendaasland, 2020-06-04 19:12 | |
| PR 20633 | merged | miss-islington, 2020-06-04 20:08 | |
| Messages (6) | |||
|---|---|---|---|
| msg370723 - (view) | Author: Erlend E. Aasland (erlendaasland) *  |
Date: 2020-06-04 19:11 | |
The insint() macro in line 741 is unused and can be removed. |
|||
| msg370725 - (view) | Author: Christian Heimes (christian.heimes) *  |
Date: 2020-06-04 19:23 | |
The other builtin hashes have the same unused macro. $ grep -R insint Modules/*.c Modules/md5module.c:#define insint(n,v) { PyModule_AddIntConstant(m,n,v); } Modules/sha1module.c:#define insint(n,v) { PyModule_AddIntConstant(m,n,v); } Modules/sha256module.c:#define insint(n,v) { PyModule_AddIntConstant(m,n,v); } Modules/sha512module.c:#define insint(n,v) { PyModule_AddIntConstant(m,n,v); } |
|||
| msg370726 - (view) | Author: Erlend E. Aasland (erlendaasland) * |
Date: 2020-06-04 19:26 | |
Indeed. I'll update the PR and the title of this issue. |
|||
| msg370727 - (view) | Author: miss-islington (miss-islington) | Date: 2020-06-04 20:08 | |
New changeset 6ed578f6dbffdec94f62cc2e36d626fc195678d7 by Erlend Egeberg Aasland in branch 'master': bpo-40865: Remove unused insint() macro from hash modules (GH-20627) https://github.com/python/cpython/commit/6ed578f6dbffdec94f62cc2e36d626fc195678d7 |
|||
| msg370728 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2020-06-04 20:09 | |
Thanks for the cleanup! The 3.9 backport will land any minute. |
|||
| msg370730 - (view) | Author: miss-islington (miss-islington) | Date: 2020-06-04 20:27 | |
New changeset e4e5ec18e2f79f9bba439b531ebf89ac148deda0 by Miss Islington (bot) in branch '3.9': bpo-40865: Remove unused insint() macro from hash modules (GH-20627) https://github.com/python/cpython/commit/e4e5ec18e2f79f9bba439b531ebf89ac148deda0 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:32 | admin | set | github: 85042 |
| 2020-06-04 20:27:27 | miss-islington | set | messages: + msg370730 |
| 2020-06-04 20:09:52 | christian.heimes | set | status: open -> closed resolution: fixed messages: + msg370728 stage: patch review -> resolved |
| 2020-06-04 20:08:57 | miss-islington | set | pull_requests: + pull_request19853 |
| 2020-06-04 20:08:47 | miss-islington | set | nosy:
+ miss-islington messages: + msg370727 |
| 2020-06-04 19:27:19 | erlendaasland | set | title: Remove unused insint() macro in SHA512 module -> Remove unused insint() macro from the hash modules |
| 2020-06-04 19:26:59 | erlendaasland | set | messages: + msg370726 |
| 2020-06-04 19:23:24 | christian.heimes | set | versions:
- Python 3.7, Python 3.8 nosy: + christian.heimes messages: + msg370725 components: + Extension Modules, - Library (Lib) type: behavior |
| 2020-06-04 19:12:31 | erlendaasland | set | keywords:
+ patch stage: patch review pull_requests: + pull_request19852 |
| 2020-06-04 19:11:01 | erlendaasland | create | |