This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: On Windows, liblzma is always built without optimization
Type: performance Stage: resolved
Components: Windows Versions: Python 3.10, Python 3.9, Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: steve.dower Nosy List: malin, miss-islington, nnemkin, paul.moore, steve.dower, tim.golden, zach.ware
Priority: normal Keywords: patch

Created on 2020-06-04 09:38 by nnemkin, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 20724 merged steve.dower, 2020-06-08 16:27
PR 20726 merged miss-islington, 2020-06-08 16:48
PR 20727 merged miss-islington, 2020-06-08 16:49
PR 20728 merged miss-islington, 2020-06-08 16:49
Messages (6)
msg370702 - (view) Author: Nikita Nemkin (nnemkin) * Date: 2020-06-04 09:38
Windows build system always builds liblzma with optimizations disabled (/Od), even in Release configuration.

Compared to optimized build (/O2), compression speed is 2-2.5x slower and module size is 30% larger.
msg370873 - (view) Author: Ma Lin (malin) * Date: 2020-06-07 04:00
Good catch.

You can submit a PR to fix this. If you start from zero and do it slowly, it will take about a week or two.
msg371013 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-06-08 16:48
New changeset 3a3a30c5a4622e18be9f7e4a239dc9e0d7c8054c by Steve Dower in branch 'master':
bpo-40861: Enable optimizations when building liblzma (GH-20724)
https://github.com/python/cpython/commit/3a3a30c5a4622e18be9f7e4a239dc9e0d7c8054c
msg371018 - (view) Author: miss-islington (miss-islington) Date: 2020-06-08 17:06
New changeset 62e7f9ab55a6426708d5316da6f07d3fe220b53a by Miss Islington (bot) in branch '3.7':
bpo-40861: Enable optimizations when building liblzma (GH-20724)
https://github.com/python/cpython/commit/62e7f9ab55a6426708d5316da6f07d3fe220b53a
msg371020 - (view) Author: miss-islington (miss-islington) Date: 2020-06-08 17:07
New changeset 30513b627777b936e3df8e4b6dd4d6b280a6b765 by Miss Islington (bot) in branch '3.8':
bpo-40861: Enable optimizations when building liblzma (GH-20724)
https://github.com/python/cpython/commit/30513b627777b936e3df8e4b6dd4d6b280a6b765
msg371021 - (view) Author: miss-islington (miss-islington) Date: 2020-06-08 17:09
New changeset 298c8c895f0d4fdd23a16f959efac83039fa1d19 by Miss Islington (bot) in branch '3.9':
bpo-40861: Enable optimizations when building liblzma (GH-20724)
https://github.com/python/cpython/commit/298c8c895f0d4fdd23a16f959efac83039fa1d19
History
Date User Action Args
2022-04-11 14:59:32adminsetgithub: 85038
2020-06-08 18:19:32steve.dowersetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2020-06-08 17:09:09miss-islingtonsetmessages: + msg371021
2020-06-08 17:07:35miss-islingtonsetmessages: + msg371020
2020-06-08 17:06:40miss-islingtonsetmessages: + msg371018
2020-06-08 16:49:13miss-islingtonsetpull_requests: + pull_request19939
2020-06-08 16:49:05miss-islingtonsetpull_requests: + pull_request19938
2020-06-08 16:48:58miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request19937
2020-06-08 16:48:46steve.dowersetmessages: + msg371013
2020-06-08 16:28:16steve.dowersetassignee: steve.dower
2020-06-08 16:27:32steve.dowersetkeywords: + patch
stage: patch review
pull_requests: + pull_request19934
2020-06-07 04:00:08malinsetnosy: + paul.moore, tim.golden, malin, zach.ware, steve.dower
messages: + msg370873
components: + Windows, - Build
2020-06-04 09:38:48nnemkincreate