classification
Title: Compiler warnings in _zoneinfo.c on Windows build in 64-bit
Type: Stage: patch review
Components: Build Versions: Python 3.10, Python 3.9
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: ammar2, corona10, p-ganssle, pablogsal, vstinner
Priority: normal Keywords: patch

Created on 2020-05-19 16:41 by vstinner, last changed 2020-06-04 14:12 by p-ganssle.

Pull Requests
URL Status Linked Edit
PR 20619 open corona10, 2020-06-03 16:48
PR 20624 open p-ganssle, 2020-06-04 14:12
Messages (6)
msg369374 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-05-19 16:41
c:\vstinner\python\3.9\modules\_zoneinfo.c(903): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\vstinner\python\3.9\PCbuild\_ 
zoneinfo.vcxproj]
c:\vstinner\python\3.9\modules\_zoneinfo.c(904): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\vstinner\python\3.9\PCbuild\_ 
zoneinfo.vcxproj]
c:\vstinner\python\3.9\modules\_zoneinfo.c(1224): warning C4068: unknown pragma [C:\vstinner\python\3.9\PCbuild\_zoneinfo.vcxproj]
c:\vstinner\python\3.9\modules\_zoneinfo.c(1225): warning C4068: unknown pragma [C:\vstinner\python\3.9\PCbuild\_zoneinfo.vcxproj]
c:\vstinner\python\3.9\modules\_zoneinfo.c(1227): warning C4068: unknown pragma [C:\vstinner\python\3.9\PCbuild\_zoneinfo.vcxproj]
c:\vstinner\python\3.9\modules\_zoneinfo.c(1770): warning C4244: '=': conversion from 'ssize_t' to 'uint8_t', possible loss of data [C:\vstinner\python\3.9\PCbuild\_zon 
einfo.vcxproj]
c:\vstinner\python\3.9\modules\_zoneinfo.c(2408): warning C4028: formal parameter 2 different from declaration [C:\vstinner\python\3.9\PCbuild\_zoneinfo.vcxproj]
msg370415 - (view) Author: Dong-hee Na (corona10) * (Python committer) Date: 2020-05-31 07:14
@pablogsal
GH-20342 looks like related to this issue.
Can you update the current status?
msg370495 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2020-05-31 18:43
> Can you update the current status?

Sorry, what do you mean by "current status"? Do you meant this issue or the status of that PR?
msg370551 - (view) Author: Dong-hee Na (corona10) * (Python committer) Date: 2020-06-01 13:51
Two things.

1. GH-20342 solved this issue?
2. If not what's left for this issue? :)

Sorry, Normally I should check the current status.
But I don't have Windows machine so I can not test it.
However the update will help contributors who want to deal with :)

Thanks Pablo
msg370597 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2020-06-02 08:21
> 1. GH-20342 solved this issue?

As far as I understand, yes. Although I did not check if all the warnings here are solved in that PR, as the PR eliminates all the ones that we found, it should be resolved.

I think we can close this issue

> Thanks Pablo

Thanks to you for all the help :)
msg370598 - (view) Author: Ammar Askar (ammar2) * (Python triager) Date: 2020-06-02 08:23
There's still the "unknown pragma" warnings left, I pinged p-ganssle about it in the zoneinfo commit but it should probably be guarded like the ones in the ssl module:

https://github.com/python/cpython/blob/a871f692b4a2e6c7d45579693e787edc0af1a02c/Modules/_ssl.c#L46
History
Date User Action Args
2020-06-04 14:12:58p-gansslesetpull_requests: + pull_request19849
2020-06-03 16:48:43corona10setkeywords: + patch
stage: patch review
pull_requests: + pull_request19845
2020-06-02 08:23:32ammar2setnosy: + ammar2
messages: + msg370598
2020-06-02 08:21:05pablogsalsetmessages: + msg370597
2020-06-01 13:51:08corona10setmessages: + msg370551
2020-05-31 18:43:44pablogsalsetmessages: + msg370495
2020-05-31 07:14:11corona10setnosy: + pablogsal, corona10
messages: + msg370415
2020-05-19 16:41:28vstinnercreate