classification
Title: PyNode_New() does not initialize n->n_col_offset
Type: Stage: resolved
Components: Interpreter Core Versions: Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Tomasz Pytel, nanjekyejoannah
Priority: normal Keywords: patch

Created on 2020-05-04 18:26 by Tomasz Pytel, last changed 2020-05-08 21:01 by nanjekyejoannah. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 19988 merged nanjekyejoannah, 2020-05-08 03:23
Messages (2)
msg368074 - (view) Author: Tomasz Pytel (Tomasz Pytel) Date: 2020-05-04 18:26
I found this by accident by compiling empty strings since I use column information from the AST tree, if not initialized I get a starting column of -842150451. The easy fix is to initialize n->n_col_offset = 0; in Parser/node.c:PyNode_New().
msg368464 - (view) Author: Joannah Nanjekye (nanjekyejoannah) * (Python committer) Date: 2020-05-08 20:58
New changeset d10091aa171250c67a5079abfe26b8b3964ea39a by Joannah Nanjekye in branch 'master':
bpo-40502: Initialize n->n_col_offset (GH-19988)
https://github.com/python/cpython/commit/d10091aa171250c67a5079abfe26b8b3964ea39a
History
Date User Action Args
2020-05-08 21:01:31nanjekyejoannahsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2020-05-08 20:58:35nanjekyejoannahsetmessages: + msg368464
2020-05-08 03:23:51nanjekyejoannahsetkeywords: + patch
nosy: + nanjekyejoannah

pull_requests: + pull_request19304
stage: patch review
2020-05-04 18:26:58Tomasz Pytelcreate