classification
Title: read_pyfile function refactor in Lib/test/test_unparse.py
Type: Stage: resolved
Components: Tests Versions: Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: hakancelik, pablogsal, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2020-04-06 18:30 by hakancelik, last changed 2020-04-16 10:26 by pablogsal. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 19399 merged hakancelik, 2020-04-06 18:34
Messages (3)
msg365875 - (view) Author: Hakan Çelik (hakancelik) * Date: 2020-04-06 18:30
The read_pyfile function can be written more effectively with the open function in the tokenize module.
msg365877 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2020-04-06 19:38
You can just use open() in binary mode.
msg366590 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2020-04-16 10:11
New changeset 6a5bf15c71a1c101c28774ae714b58e8a65b130c by Hakan Çelik in branch 'master':
bpo-40209: Use tokenize.open in test_unparse (GH-19399)
https://github.com/python/cpython/commit/6a5bf15c71a1c101c28774ae714b58e8a65b130c
History
Date User Action Args
2020-04-16 10:26:35pablogsalsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2020-04-16 10:11:58pablogsalsetnosy: + pablogsal
messages: + msg366590
2020-04-06 19:38:45serhiy.storchakasetnosy: + serhiy.storchaka
messages: + msg365877
2020-04-06 18:34:25hakanceliksetkeywords: + patch
stage: patch review
pull_requests: + pull_request18761
2020-04-06 18:30:46hakancelikcreate