classification
Title: const strings in Modules/_datetimemodule.c and Modules/_testbuffer.c
Type: Stage: resolved
Components: Interpreter Core Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, petdance
Priority: normal Keywords: patch

Created on 2020-02-24 04:24 by petdance, last changed 2020-02-24 06:40 by benjamin.peterson. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 18637 merged petdance, 2020-02-24 04:26
Messages (2)
msg362565 - (view) Author: Andy Lester (petdance) * Date: 2020-02-24 04:24
In Modules/_datetimemodule.c, the char *timespec and char *specs[] can be made const.  Their contents are never modified.

In ndarray_get_format in Modules/_testbuffer.c, char *fmt can be made const.
msg362570 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2020-02-24 06:40
New changeset c3fa634096eedbaf477698adab666f03085a7928 by Andy Lester in branch 'master':
closes bpo-39736: const strings in Modules/_datetimemodule.c and Modules/_testbuffer.c (GH-18637)
https://github.com/python/cpython/commit/c3fa634096eedbaf477698adab666f03085a7928
History
Date User Action Args
2020-02-24 06:40:55benjamin.petersonsetstatus: open -> closed

nosy: + benjamin.peterson
messages: + msg362570

resolution: fixed
stage: patch review -> resolved
2020-02-24 04:26:48petdancesetkeywords: + patch
stage: patch review
pull_requests: + pull_request18003
2020-02-24 04:24:30petdancecreate