➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2020-01-17 17:47 by pablogsal, last changed 2022-04-11 14:59 by admin.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 18037 | merged | pablogsal, 2020-01-17 17:48 | |
| Messages (8) | |||
|---|---|---|---|
| msg360204 - (view) | Author: Pablo Galindo Salgado (pablogsal) *  |
Date: 2020-01-17 17:47 | |
There are many declarations that lack definitions in our header files that should be cleaned (linking against those symbols will fail so removing them should be safe if I am not missing something). |
|||
| msg360207 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2020-01-17 19:10 | |
Good catch! All removals LGTM. |
|||
| msg360229 - (view) | Author: Pablo Galindo Salgado (pablogsal) * |
Date: 2020-01-18 03:15 | |
New changeset cd7db76a636c218b2d81d3526eb435cfae61f212 by Pablo Galindo in branch 'master': bpo-39372: Clean header files of declared interfaces with no implementations (GH-18037) https://github.com/python/cpython/commit/cd7db76a636c218b2d81d3526eb435cfae61f212 |
|||
| msg360238 - (view) | Author: Zackery Spytz (ZackerySpytz) *  |
Date: 2020-01-18 06:57 | |
The removal of PyNoArgsFunction is the subject of bpo-18091. |
|||
| msg360240 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2020-01-18 09:06 | |
Maybe backport this change (except PyNoArgsFunction)? |
|||
| msg360246 - (view) | Author: Pablo Galindo Salgado (pablogsal) * |
Date: 2020-01-18 14:36 | |
> Maybe backport this change (except PyNoArgsFunction)? I didn't think of backporting to reduce the possibilities of something going wrong, but is true that a backport without PyNoArgsFunction should be harmless. Reopening the issue meanwhile I do on the backports. |
|||
| msg371083 - (view) | Author: Petr Viktorin (petr.viktorin) * |
Date: 2020-06-09 08:23 | |
Since the removal of PyNoArgsFunction breaks user code, does it deserve a mention in What's New – Porting to Python 3.9? |
|||
| msg371125 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2020-06-09 16:44 | |
> Maybe backport this change (except PyNoArgsFunction)? I don't think that it's a good idea. I suggest to only do cleanup in the master branch, just in case if something goes wrong. Like the PyNoArgsFunction removal :-) |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:25 | admin | set | github: 83553 |
| 2020-06-09 16:44:46 | vstinner | set | nosy:
+ vstinner messages: + msg371125 |
| 2020-06-09 08:23:46 | petr.viktorin | set | nosy:
+ petr.viktorin messages: + msg371083 |
| 2020-01-18 14:36:32 | pablogsal | set | status: closed -> open resolution: fixed -> messages: + msg360246 |
| 2020-01-18 09:27:00 | serhiy.storchaka | link | issue18091 superseder |
| 2020-01-18 09:06:06 | serhiy.storchaka | set | messages: + msg360240 |
| 2020-01-18 06:57:02 | ZackerySpytz | set | nosy:
+ ZackerySpytz messages: + msg360238 |
| 2020-01-18 03:15:46 | pablogsal | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2020-01-18 03:15:05 | pablogsal | set | messages: + msg360229 |
| 2020-01-17 19:10:22 | serhiy.storchaka | set | nosy:
+ serhiy.storchaka messages: + msg360207 |
| 2020-01-17 17:48:33 | pablogsal | set | keywords:
+ patch stage: patch review pull_requests: + pull_request17436 |
| 2020-01-17 17:47:14 | pablogsal | create | |