classification
Title: select.epoll.unregister(fd) should not ignore EBADF
Type: Stage: resolved
Components: Library (Lib) Versions: Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: christian.heimes, vstinner
Priority: normal Keywords: patch

Created on 2020-01-06 23:34 by vstinner, last changed 2020-01-07 20:41 by vstinner. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 17882 merged vstinner, 2020-01-06 23:39
Messages (2)
msg359481 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-01-06 23:34
The select.epoll.unregister(fd) method currently ignores EBADF error if the file descriptor fd is invalid.

I'm surprised by this undocumented behavior:
https://docs.python.org/dev/library/select.html#select.epoll.unregister

This behavior may lead to bugs if the file descriptor number has been recycled in the meanwhile. I'm not sure that it's a good idea to silently ignore the error.

See bpo-18748 for a similar issue: "io.IOBase destructor silence I/O error on close() by default".

Note: The method also ignores EBADF error if the epoll file descriptor has been closed.

The behavior is as old as the implementation of select.epoll, bpo-1657:

commit 0e9ab5f2f0f907b57c70557e21633ce8c341d1d1
Author: Christian Heimes <christian@cheimes.de>
Date:   Fri Mar 21 23:49:44 2008 +0000

    Applied patch #1657 epoll and kqueue wrappers for the select module
    The patch adds wrappers for the Linux epoll syscalls and the BSD kqueue syscalls. Thanks to Thomas Herve and the Twisted people for their support a
nd help.
    TODO: Finish documentation documentation

Thomas Herve wrote a first implementation in bpo-1675118, but it seems like it was Christian Heimes who wrote the unregister() method.
msg359511 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-01-07 14:00
New changeset 5b23f7618d434f3000bde482233c8642a6eb2c67 by Victor Stinner in branch 'master':
bpo-39239: epoll.unregister() no longer ignores EBADF (GH-17882)
https://github.com/python/cpython/commit/5b23f7618d434f3000bde482233c8642a6eb2c67
History
Date User Action Args
2020-01-07 20:41:57vstinnersetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2020-01-07 14:00:06vstinnersetmessages: + msg359511
2020-01-06 23:39:26vstinnersetkeywords: + patch
stage: patch review
pull_requests: + pull_request17298
2020-01-06 23:34:48vstinnercreate