➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Lock may not be released in Logger.isEnabledFor
Type: crash Stage: resolved
Components: Library (Lib) Versions: Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: derektbrown, vinay.sajip
Priority: normal Keywords: patch

Created on 2020-01-02 20:10 by derektbrown, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 17689 merged derektbrown, 2020-01-02 20:12
PR 17897 merged miss-islington, 2020-01-07 16:41
PR 17898 merged miss-islington, 2020-01-07 16:41
Messages (5)
msg359219 - (view) Author: Derek Brown (derektbrown) * Date: 2020-01-02 20:10 
If an exception were to be thrown in a particular block of code (say, by asyncio timeouts or stopit) within the `isEnabledFor` function of `logging`, the `logging` global lock may not be released appropriately, resulting in deadlock.
msg359220 - (view) Author: Derek Brown (derektbrown) * Date: 2020-01-02 20:19 
PR is here: https://github.com/python/cpython/pull/17689
msg359520 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2020-01-07 16:40 
New changeset 950c6795aa0ffa85e103a13e7a04e08cb34c66ad by Vinay Sajip (Derek Brown) in branch 'master':
bpo-39198: Ensure logging global lock is released on exception in isEnabledFor (GH-17689)
https://github.com/python/cpython/commit/950c6795aa0ffa85e103a13e7a04e08cb34c66ad
msg359521 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2020-01-07 17:03 
New changeset bff48c6734f936257b0cfae58dbea67d43e3b245 by Vinay Sajip (Miss Islington (bot)) in branch '3.8':
bpo-39198: Ensure logging global lock is released on exception in isEnabledFor (GH-17689) (GH-17897)
https://github.com/python/cpython/commit/bff48c6734f936257b0cfae58dbea67d43e3b245
msg359522 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2020-01-07 17:03 
New changeset d46dec981abdefba56336521c7587c8554bb1b9d by Vinay Sajip (Miss Islington (bot)) in branch '3.7':
bpo-39198: Ensure logging global lock is released on exception in isEnabledFor (GH-17689) (GH-17898)
https://github.com/python/cpython/commit/d46dec981abdefba56336521c7587c8554bb1b9d
History
Date User Action Args
2022-04-11 14:59:24adminsetgithub: 83379
2020-01-07 17:04:16vinay.sajipsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2020-01-07 17:03:53vinay.sajipsetmessages: + msg359522
2020-01-07 17:03:30vinay.sajipsetmessages: + msg359521
2020-01-07 16:41:52miss-islingtonsetpull_requests: + pull_request17308
2020-01-07 16:41:20miss-islingtonsetpull_requests: + pull_request17307
2020-01-07 16:40:30vinay.sajipsetmessages: + msg359520
2020-01-05 03:05:15ned.deilysetnosy: + vinay.sajip
2020-01-02 20:19:01derektbrownsetmessages: + msg359220
2020-01-02 20:12:13derektbrownsetkeywords: + patch
stage: patch review
pull_requests: + pull_request17236
2020-01-02 20:10:20derektbrowncreate