This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Py_USING_MEMORY_DEBUGGER is referenced in docs but not present in code
Type: Stage: resolved
Components: Build Versions: Python 3.11, Python 3.10, Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: BTaskaya, Sümer.Cip, benjamin.peterson, carlosdamazio, dmzz, miss-islington
Priority: normal Keywords: easy, patch

Created on 2019-10-18 22:01 by Sümer.Cip, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 30284 merged dmzz, 2021-12-28 19:26
PR 30295 merged miss-islington, 2021-12-29 22:21
PR 30296 merged miss-islington, 2021-12-29 22:21
Messages (4)
msg354922 - (view) Author: Sümer Cip (Sümer.Cip) Date: 2019-10-18 22:01
Hi all,

While trying to debug Python C extension via valgrind, I was reading the document Misc/README.valgrind and it seems there are some parts not being uptodate. There is comments comments like following:

Uncomment Py_USING_MEMORY_DEBUGGER in Objects/obmalloc.c, then rebuild Python. This define seems to be removed from the obmalloc.c file and also I am not sure if anything is using it at all. When I searched the code, only Python/dtoa.c have a reference to this define. Anyway, I have not specifically investigated the reason behind of the removal of the define but it seems it is removed somewhere between 3.3 and 3.4. I am assuming it might be related with tracemalloc maybe? 

Cheers,
msg355010 - (view) Author: Batuhan Taskaya (BTaskaya) * (Python committer) Date: 2019-10-20 17:20
It looks like benjamin peterson removed remaining references from obmalloc.c in 3924f93794fd740c547b44884f73303196475cd5
msg409327 - (view) Author: Carlos Damazio (carlosdamazio) * Date: 2021-12-29 20:48
Opened a PR for this issue. It'll remove the mentions to the `Py_USING_MEMORY_DEBUGGER` since it'd been removed 5 years ago.
msg409333 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2021-12-29 23:01
New changeset 9f0e40fae5191c3e3ed6109bd2e2f97aa0ac8d64 by Miss Islington (bot) in branch '3.10':
closes bpo-38522 docs: remove references to Py_USING_MEMORY_DEBUGGER (GH-30284) (GH-30295)
https://github.com/python/cpython/commit/9f0e40fae5191c3e3ed6109bd2e2f97aa0ac8d64
History
Date User Action Args
2022-04-11 14:59:21adminsetgithub: 82703
2021-12-29 23:01:25benjamin.petersonsetstatus: open -> closed
resolution: fixed
messages: + msg409333

stage: patch review -> resolved
2021-12-29 22:21:44miss-islingtonsetpull_requests: + pull_request28509
2021-12-29 22:21:21miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request28508
2021-12-29 20:48:08carlosdamaziosetnosy: + carlosdamazio
messages: + msg409327
2021-12-28 19:26:25dmzzsetkeywords: + patch
nosy: + dmzz

pull_requests: + pull_request28498
stage: patch review
2021-12-06 23:27:05iritkatrielsetkeywords: + easy
versions: + Python 3.10, Python 3.11, - Python 2.7, Python 3.5, Python 3.6, Python 3.7, Python 3.8
2019-10-20 17:20:29BTaskayasetnosy: + benjamin.peterson, BTaskaya
messages: + msg355010
2019-10-18 22:01:41Sümer.Cipsetversions: + Python 2.7, Python 3.5
2019-10-18 22:01:11Sümer.Cipcreate