classification
Title: Py_USING_MEMORY_DEBUGGER is referenced in docs but not present in code
Type: Stage:
Components: Build Versions: Python 3.9, Python 3.8, Python 3.7, Python 3.6, Python 3.5, Python 2.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: BTaskaya, Sümer.Cip, benjamin.peterson
Priority: normal Keywords:

Created on 2019-10-18 22:01 by Sümer.Cip, last changed 2019-10-20 17:20 by BTaskaya.

Messages (2)
msg354922 - (view) Author: Sümer Cip (Sümer.Cip) Date: 2019-10-18 22:01
Hi all,

While trying to debug Python C extension via valgrind, I was reading the document Misc/README.valgrind and it seems there are some parts not being uptodate. There is comments comments like following:

Uncomment Py_USING_MEMORY_DEBUGGER in Objects/obmalloc.c, then rebuild Python. This define seems to be removed from the obmalloc.c file and also I am not sure if anything is using it at all. When I searched the code, only Python/dtoa.c have a reference to this define. Anyway, I have not specifically investigated the reason behind of the removal of the define but it seems it is removed somewhere between 3.3 and 3.4. I am assuming it might be related with tracemalloc maybe? 

Cheers,
msg355010 - (view) Author: Batuhan Taskaya (BTaskaya) * (Python committer) Date: 2019-10-20 17:20
It looks like benjamin peterson removed remaining references from obmalloc.c in 3924f93794fd740c547b44884f73303196475cd5
History
Date User Action Args
2019-10-20 17:20:29BTaskayasetnosy: + benjamin.peterson, BTaskaya
messages: + msg355010
2019-10-18 22:01:41Sümer.Cipsetversions: + Python 2.7, Python 3.5
2019-10-18 22:01:11Sümer.Cipcreate