classification
Title: Internal include files missing on Windows
Type: compile error Stage: patch review
Components: Windows Versions: Python 3.9, Python 3.8
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: steve.dower Nosy List: ZackerySpytz, miss-islington, paul.moore, steve.dower, tim.golden, zach.ware
Priority: normal Keywords: patch

Created on 2019-10-18 18:30 by steve.dower, last changed 2019-10-28 17:23 by miss-islington.

Pull Requests
URL Status Linked Edit
PR 16921 merged ZackerySpytz, 2019-10-25 05:46
PR 16966 merged miss-islington, 2019-10-28 17:04
Messages (5)
msg354914 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2019-10-18 18:30
The include/internal directory is not being included in the packages published to nuget.org or the Microsoft Store.

This prevents some advanced users from being able to compile against these packages.
msg354915 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2019-10-18 18:33
If someone wants to fix this before I do, the change goes in PC/layout/main.py to remove the filter for directories named "internal" - we shouldn't need a filter there at all now that we include everything in the distro.
msg355353 - (view) Author: Zackery Spytz (ZackerySpytz) * (Python triager) Date: 2019-10-25 05:50
Hi, Steve. I've created a PR for this.
msg355568 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2019-10-28 17:03
New changeset edb172a87296d9359593a23cd9a09f5867ea1f0e by Steve Dower (Zackery Spytz) in branch 'master':
bpo-38519: Internal include files missing on Windows (GH-16921)
https://github.com/python/cpython/commit/edb172a87296d9359593a23cd9a09f5867ea1f0e
msg355571 - (view) Author: miss-islington (miss-islington) Date: 2019-10-28 17:23
New changeset 07eee640cb3a4eaf1df942bc31a891e7517de763 by Miss Skeleton (bot) in branch '3.8':
bpo-38519: Internal include files missing on Windows (GH-16921)
https://github.com/python/cpython/commit/07eee640cb3a4eaf1df942bc31a891e7517de763
History
Date User Action Args
2019-10-28 17:23:13miss-islingtonsetnosy: + miss-islington
messages: + msg355571
2019-10-28 17:04:04miss-islingtonsetpull_requests: + pull_request16493
2019-10-28 17:03:37steve.dowersetmessages: + msg355568
2019-10-25 05:50:54ZackerySpytzsetnosy: + ZackerySpytz
messages: + msg355353
2019-10-25 05:46:28ZackerySpytzsetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request16453
2019-10-18 18:33:26steve.dowersetmessages: + msg354915
2019-10-18 18:30:38steve.dowercreate