➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2019-10-13 16:04 by srittau, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 16753 | merged | srittau, 2019-10-13 18:19 | |
| PR 16754 | merged | miss-islington, 2019-10-13 18:31 | |
| Messages (5) | |||
|---|---|---|---|
| msg354590 - (view) | Author: Sebastian Rittau (srittau) * | Date: 2019-10-13 16:04 | |
The arguments for typing.get_origin() and typing.get_args() are named "typ" in the documentation (https://docs.python.org/3.8/library/typing.html#typing.get_origin), while they are named "tp" in the implementation. Important if used as keyword argument. |
|||
| msg354596 - (view) | Author: Ivan Levkivskyi (levkivskyi) *  |
Date: 2019-10-13 18:10 | |
I think adjusting the docs would be less disruptive than changing implementation. Would you like to make a PR? |
|||
| msg354597 - (view) | Author: Sebastian Rittau (srittau) * | Date: 2019-10-13 18:20 | |
https://github.com/python/cpython/pull/16753 |
|||
| msg354599 - (view) | Author: Ivan Levkivskyi (levkivskyi) * |
Date: 2019-10-13 18:31 | |
New changeset fdfe2833ace93021278fe4c41c40e1d08d70abf9 by Ivan Levkivskyi (Sebastian Rittau) in branch 'master': bpo-38467: Fix argument name of typing functions (GH-16753) https://github.com/python/cpython/commit/fdfe2833ace93021278fe4c41c40e1d08d70abf9 |
|||
| msg354600 - (view) | Author: miss-islington (miss-islington) | Date: 2019-10-13 18:38 | |
New changeset c732660b7b18352ba8524ac78d39975afe4392ef by Miss Islington (bot) in branch '3.8': bpo-38467: Fix argument name of typing functions (GH-16753) https://github.com/python/cpython/commit/c732660b7b18352ba8524ac78d39975afe4392ef |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:21 | admin | set | github: 82648 |
| 2019-10-13 18:47:25 | levkivskyi | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2019-10-13 18:38:48 | miss-islington | set | nosy:
+ miss-islington messages: + msg354600 |
| 2019-10-13 18:31:47 | miss-islington | set | pull_requests: + pull_request16327 |
| 2019-10-13 18:31:39 | levkivskyi | set | messages: + msg354599 |
| 2019-10-13 18:20:11 | srittau | set | messages: + msg354597 |
| 2019-10-13 18:19:14 | srittau | set | keywords:
+ patch stage: patch review pull_requests: + pull_request16326 |
| 2019-10-13 18:10:26 | levkivskyi | set | messages: + msg354596 |
| 2019-10-13 17:18:19 | xtreak | set | nosy:
+ levkivskyi |
| 2019-10-13 16:04:33 | srittau | create | |