classification
Title: Version name in PC/layout read incorrectly for RC
Type: behavior Stage: resolved
Components: Windows Versions: Python 3.9, Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: steve.dower Nosy List: lukasz.langa, miss-islington, paul.moore, steve.dower, tim.golden, zach.ware
Priority: normal Keywords: 3.8regression, patch

Created on 2019-10-01 23:01 by steve.dower, last changed 2019-10-02 00:01 by steve.dower. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 16527 merged steve.dower, 2019-10-01 23:09
PR 16528 merged miss-islington, 2019-10-01 23:42
Messages (4)
msg353715 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2019-10-01 23:01
I noticed that when the nuget.org packages published for 3.8.0rc1, they were given the version "3.8.0".

3.7.5rc1 was okay because it's still using the old approach to setting the version.

This needs to be fixed before any more RCs are released. I'll see if I can get the incorrectly versioned files removed from nuget and replace them with RCs.
msg353716 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2019-10-01 23:42
New changeset b9a8b8296cd7be22f8b5bf92af686a788c47c7bf by Steve Dower in branch 'master':
bpo-38343: Fixes version handling for nuget packages (GH-16527)
https://github.com/python/cpython/commit/b9a8b8296cd7be22f8b5bf92af686a788c47c7bf
msg353717 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2019-10-01 23:46
I already republished correctly-versioned files and unlisted the wrong ones (as well as contacting support to see whether they can delete them completely so they don't impact the final release).

The change above fixes the issue. It will need cherry-picking for the v3.8.0 tag (or the v3.8.0rc2 tag...).
msg353718 - (view) Author: miss-islington (miss-islington) Date: 2019-10-02 00:00
New changeset a11df75269b5d47248be617ed02e96c1d1938fd1 by Miss Islington (bot) in branch '3.8':
bpo-38343: Fixes version handling for nuget packages (GH-16527)
https://github.com/python/cpython/commit/a11df75269b5d47248be617ed02e96c1d1938fd1
History
Date User Action Args
2019-10-02 00:01:20steve.dowersetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2019-10-02 00:00:52miss-islingtonsetnosy: + miss-islington
messages: + msg353718
2019-10-01 23:46:06steve.dowersetmessages: + msg353717
2019-10-01 23:42:37miss-islingtonsetpull_requests: + pull_request16119
2019-10-01 23:42:31steve.dowersetmessages: + msg353716
2019-10-01 23:09:37steve.dowersetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request16118
2019-10-01 23:04:16steve.dowersetnosy: + lukasz.langa
2019-10-01 23:01:39steve.dowercreate