➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Fix invocation of EchoClientProtocol
Type: Stage: resolved
Components: asyncio, Documentation Versions: Python 3.9, Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: asvetlov, docs@python, hniksic, miss-islington, yselivanov
Priority: normal Keywords: patch

Created on 2019-09-16 20:34 by hniksic, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 16202 merged hniksic, 2019-09-16 20:35
PR 16218 merged miss-islington, 2019-09-17 07:17
PR 16219 merged miss-islington, 2019-09-17 07:17
Messages (4)
msg352584 - (view) Author: Hrvoje Nikšić (hniksic) * Date: 2019-09-16 20:34 
This is a followup on issue38178. While testing the new code, I noticed that my change introduced a bug, where the code still attempts to pass "loop" when constructing an EchoClientProtocol. A pull request is attached.

Also, I've noticed that the MyProtocol example under "Connecting Existing Sockets" is still passing an explicit loop, so I created a commit that converts it to the on_con_lost idiom, and included it in the above pull request.
msg352616 - (view) Author: miss-islington (miss-islington) Date: 2019-09-17 07:16 
New changeset 5d359cc62e0244e1fd8d17146a4135079d6843bf by Miss Islington (bot) (Hrvoje Nikšić) in branch 'master':
bpo-38192: Fix remaining passing of "loop" in the protocol examples (GH-16202)
https://github.com/python/cpython/commit/5d359cc62e0244e1fd8d17146a4135079d6843bf
msg352617 - (view) Author: miss-islington (miss-islington) Date: 2019-09-17 07:22 
New changeset facbd316b409f3775da2a74d0845938b4c7b88f0 by Miss Islington (bot) in branch '3.7':
bpo-38192: Fix remaining passing of "loop" in the protocol examples (GH-16202)
https://github.com/python/cpython/commit/facbd316b409f3775da2a74d0845938b4c7b88f0
msg352618 - (view) Author: miss-islington (miss-islington) Date: 2019-09-17 07:24 
New changeset 1ba74719e3a213a2c473b92f3a79f8399e65f80a by Miss Islington (bot) in branch '3.8':
bpo-38192: Fix remaining passing of "loop" in the protocol examples (GH-16202)
https://github.com/python/cpython/commit/1ba74719e3a213a2c473b92f3a79f8399e65f80a
History
Date User Action Args
2022-04-11 14:59:20adminsetgithub: 82373
2019-09-17 07:31:44asvetlovsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2019-09-17 07:24:34miss-islingtonsetmessages: + msg352618
2019-09-17 07:22:51miss-islingtonsetmessages: + msg352617
2019-09-17 07:17:09miss-islingtonsetpull_requests: + pull_request15820
2019-09-17 07:17:00miss-islingtonsetpull_requests: + pull_request15819
2019-09-17 07:16:46miss-islingtonsetnosy: + miss-islington
messages: + msg352616
2019-09-16 20:35:05hniksicsetkeywords: + patch
stage: patch review
pull_requests: + pull_request15806
2019-09-16 20:34:18hniksiccreate