This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: PyState_AddModule docs should say that it's not necessary to call it.
Type: Stage: resolved
Components: Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: miss-islington, petr.viktorin
Priority: normal Keywords: patch

Created on 2019-09-13 13:25 by petr.viktorin, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 16101 merged petr.viktorin, 2019-09-13 13:26
PR 17026 merged miss-islington, 2019-11-01 15:47
PR 17027 merged miss-islington, 2019-11-01 15:47
Messages (4)
msg352320 - (view) Author: Petr Viktorin (petr.viktorin) * (Python committer) Date: 2019-09-13 13:25
I've seen extension modules calling PyState_AddModule on init, despite  Python doing this automatically.
It should be clarified that PyState_AddModule is for people who are writing alternative ways of creating/registering module objects.
msg355823 - (view) Author: Petr Viktorin (petr.viktorin) * (Python committer) Date: 2019-11-01 15:47
New changeset 9bc94eca0c69a551f928692364a99e9b67c4a45b by Petr Viktorin in branch 'master':
bpo-38159: Clarify documentation of PyState_AddModule (GH-16101)
https://github.com/python/cpython/commit/9bc94eca0c69a551f928692364a99e9b67c4a45b
msg356033 - (view) Author: miss-islington (miss-islington) Date: 2019-11-05 13:36
New changeset 4342af00d87de0a0d0ef3bfda4d6edb08ac2427a by Miss Islington (bot) in branch '3.7':
[3.7] bpo-38159: Clarify documentation of PyState_AddModule (GH-16101) (GH-17027)
https://github.com/python/cpython/commit/4342af00d87de0a0d0ef3bfda4d6edb08ac2427a
msg356034 - (view) Author: miss-islington (miss-islington) Date: 2019-11-05 14:12
New changeset 1270d2cf1d17bfa581bf2a19f82c8cb43bf793d9 by Miss Islington (bot) in branch '3.8':
[3.8] bpo-38159: Clarify documentation of PyState_AddModule (GH-16101) (GH-17026)
https://github.com/python/cpython/commit/1270d2cf1d17bfa581bf2a19f82c8cb43bf793d9
History
Date User Action Args
2022-04-11 14:59:20adminsetgithub: 82340
2019-11-06 14:23:10petr.viktorinsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2019-11-05 14:12:57miss-islingtonsetmessages: + msg356034
2019-11-05 13:36:16miss-islingtonsetnosy: + miss-islington
messages: + msg356033
2019-11-01 15:47:49miss-islingtonsetpull_requests: + pull_request16542
2019-11-01 15:47:43miss-islingtonsetpull_requests: + pull_request16541
2019-11-01 15:47:23petr.viktorinsetmessages: + msg355823
2019-09-13 13:26:15petr.viktorinsetkeywords: + patch
stage: patch review
pull_requests: + pull_request15720
2019-09-13 13:25:39petr.viktorincreate