classification
Title: hashopenssl fails to compile on MacOS
Type: Stage: resolved
Components: Build, macOS Versions: Python 3.9
process
Status: closed Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: christian.heimes, miss-islington, ned.deily, pablogsal, ronaldoussoren
Priority: normal Keywords: patch

Created on 2019-09-12 13:36 by pablogsal, last changed 2020-12-12 13:52 by christian.heimes. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 16051 merged christian.heimes, 2019-09-12 14:16
PR 16057 merged matrixise, 2019-09-12 14:38
Messages (5)
msg352161 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2019-09-12 13:36
I get this when compiling CPython master

Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:89:19: error: implicit declaration of function 'EVP_MD_CTX_new' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    retval->ctx = EVP_MD_CTX_new();
                  ^
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:89:19: warning: this function declaration is not a prototype [-Wstrict-prototypes]
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:89:17: warning: incompatible integer to pointer conversion assigning to 'EVP_MD_CTX *' (aka 'struct env_md_ctx_st *') from 'int' [-Wint-conversion]
    retval->ctx = EVP_MD_CTX_new();
                ^ ~~~~~~~~~~~~~~~~
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:126:5: error: implicit declaration of function 'EVP_MD_CTX_free' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    EVP_MD_CTX_free(self->ctx);
    ^
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:126:5: note: did you mean 'EVP_MD_CTX_create'?
/usr/local/opt/openssl/include/openssl/evp.h:588:13: note: 'EVP_MD_CTX_create' declared here
EVP_MD_CTX *EVP_MD_CTX_create(void);
            ^
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:126:5: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    EVP_MD_CTX_free(self->ctx);
    ^
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:179:16: error: implicit declaration of function 'EVP_MD_CTX_new' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    temp_ctx = EVP_MD_CTX_new();
               ^
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:179:14: warning: incompatible integer to pointer conversion assigning to 'EVP_MD_CTX *' (aka 'struct env_md_ctx_st *') from 'int' [-Wint-conversion]
    temp_ctx = EVP_MD_CTX_new();
             ^ ~~~~~~~~~~~~~~~~
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:195:5: error: implicit declaration of function 'EVP_MD_CTX_free' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    EVP_MD_CTX_free(temp_ctx);
    ^
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:213:16: error: implicit declaration of function 'EVP_MD_CTX_new' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    temp_ctx = EVP_MD_CTX_new();
               ^
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:213:14: warning: incompatible integer to pointer conversion assigning to 'EVP_MD_CTX *' (aka 'struct env_md_ctx_st *') from 'int' [-Wint-conversion]
    temp_ctx = EVP_MD_CTX_new();
             ^ ~~~~~~~~~~~~~~~~
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:229:5: error: implicit declaration of function 'EVP_MD_CTX_free' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    EVP_MD_CTX_free(temp_ctx);


❯ openssl version
LibreSSL 2.6.5
msg352177 - (view) Author: miss-islington (miss-islington) Date: 2019-09-12 14:33
New changeset 9a4963b932a087b78596cca0b8394ac898faa490 by Miss Islington (bot) (Christian Heimes) in branch 'master':
bpo-38137: Re-add OpenSSL 1.0.2 compat (GH-16051)
https://github.com/python/cpython/commit/9a4963b932a087b78596cca0b8394ac898faa490
msg352191 - (view) Author: miss-islington (miss-islington) Date: 2019-09-12 14:57
New changeset 36c29e444d6bc0e31b46509610d3fb7cff74f2c2 by Miss Islington (bot) (Stéphane Wirtel) in branch '3.8':
[3.8] bpo-38137: Re-add OpenSSL 1.0.2 compat (GH-16051) (GH-16057)
https://github.com/python/cpython/commit/36c29e444d6bc0e31b46509610d3fb7cff74f2c2
msg382909 - (view) Author: Ronald Oussoren (ronaldoussoren) * (Python committer) Date: 2020-12-12 12:43
can this issue be closed?
msg382912 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2020-12-12 13:52
I don't have access to macOS. Did the PR fix the issue?
History
Date User Action Args
2020-12-12 13:52:09christian.heimessetstatus: open -> closed

messages: + msg382912
stage: patch review -> resolved
2020-12-12 12:43:20ronaldoussorensetnosy: + ned.deily
components: + macOS
2020-12-12 12:43:09ronaldoussorensetnosy: + ronaldoussoren
messages: + msg382909
2019-09-12 14:57:06miss-islingtonsetmessages: + msg352191
2019-09-12 14:38:11matrixisesetpull_requests: + pull_request15680
2019-09-12 14:33:30miss-islingtonsetnosy: + miss-islington
messages: + msg352177
2019-09-12 14:16:00christian.heimessetkeywords: + patch
stage: patch review
pull_requests: + pull_request15675
2019-09-12 13:36:09pablogsalcreate