➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2019-09-05 14:19 by corona10, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 15703 | merged | corona10, 2019-09-05 14:23 | |
| Messages (9) | |||
|---|---|---|---|
| msg351199 - (view) | Author: Dong-hee Na (corona10) *  |
Date: 2019-09-05 14:19 | |
This issue is the same as bpo-22347. Let's remove the deprecated urllib.parse._splituser and urllib.parse._splittype from xmlrpc.client |
|||
| msg351318 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2019-09-08 08:54 | |
New changeset 9c4c459ac66c86a4511c8fec1997e8760e15ec17 by Serhiy Storchaka (Dong-hee Na) in branch 'master': bpo-38038: Remove urllib.parse._splittype from xmlrpc.client. (GH-15703) https://github.com/python/cpython/commit/9c4c459ac66c86a4511c8fec1997e8760e15ec17 |
|||
| msg351362 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2019-09-09 08:49 | |
> Let's remove the deprecated urllib.parse._splituser and urllib.parse._splittype from xmlrpc.client splittype() is deprecated, _splittype() is not deprecated. Should we deprecate _splittype() as well? I don't know the rationale of splittype() deprecation. |
|||
| msg351375 - (view) | Author: Dong-hee Na (corona10) * |
Date: 2019-09-09 09:24 | |
@vstinner Right. splittype() is deprecated. Nevertheless, the same functionality is still accessible to end users with _splittype (). So I thought we should go in the direction of removing this completely. From the view of the standard library is used by Python end users as a reference for their own implementation, I suggest removing indirectly usage of deprecated API gradually. |
|||
| msg351388 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2019-09-09 09:50 | |
splittype() was deprecated in Python 3.8 by bpo-27485: commit 0250de48199552cdaed5a4fe44b3f9cdb5325363 Author: Cheryl Sabella <cheryl.sabella@gmail.com> Date: Wed Apr 25 16:51:54 2018 -0700 bpo-27485: Rename and deprecate undocumented functions in urllib.parse (GH-2205) Dong-hee Na: This issue is about xmlrpc.client. If you consider that it's time to remove deprecated urllib.parse functions, please open a separated issue. |
|||
| msg351397 - (view) | Author: Dong-hee Na (corona10) * |
Date: 2019-09-09 09:58 | |
Understood |
|||
| msg389617 - (view) | Author: frathgeber (kynan) | Date: 2021-03-27 21:36 | |
This change caused an (I presume unintended) behavior change that breaks some xmlrpc users: previously, the XLMRPC handler was everything after the host part of the URI (https://github.com/python/cpython/blame/32f825393e5836ab71de843596379fa3f9e23c7a/Lib/xmlrpc/client.py#L1428), but now the query string is *discarded* (https://github.com/python/cpython/blame/63298930fb531ba2bb4f23bc3b915dbf1e17e9e1/Lib/xmlrpc/client.py#L1424). This is known to break the XMLRPC for DokuWiki (https://www.dokuwiki.org/devel:xmlrpc), which uses query parameters for authentication: https://github.com/kynan/dokuwikixmlrpc/issues/8 |
|||
| msg389618 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2021-03-27 21:46 | |
Please open a new bug and include a reference to this issue. |
|||
| msg389633 - (view) | Author: frathgeber (kynan) | Date: 2021-03-28 09:22 | |
Filed bpo-43645 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:19 | admin | set | github: 82219 |
| 2021-03-28 09:22:04 | kynan | set | messages: + msg389633 |
| 2021-03-27 21:46:34 | christian.heimes | set | nosy:
+ christian.heimes messages: + msg389618 |
| 2021-03-27 21:36:01 | kynan | set | nosy:
+ kynan messages: + msg389617 |
| 2019-09-09 09:58:11 | corona10 | set | messages: + msg351397 |
| 2019-09-09 09:50:24 | vstinner | set | messages: + msg351388 |
| 2019-09-09 09:24:48 | corona10 | set | messages: + msg351375 |
| 2019-09-09 08:49:52 | vstinner | set | messages: + msg351362 |
| 2019-09-08 09:06:09 | corona10 | set | status: open -> closed stage: patch review -> resolved resolution: fixed versions: - Python 3.7, Python 3.8 |
| 2019-09-08 08:54:18 | serhiy.storchaka | set | messages: + msg351318 |
| 2019-09-05 16:56:29 | corona10 | set | title: Remove urllib.parse._ from xmlrpc.client -> Remove urllib.parse._splittype from xmlrpc.client |
| 2019-09-05 14:24:19 | corona10 | set | nosy:
+ cheryl.sabella |
| 2019-09-05 14:23:15 | corona10 | set | keywords:
+ patch stage: patch review pull_requests: + pull_request15357 |
| 2019-09-05 14:20:33 | corona10 | set | versions: + Python 3.7 |
| 2019-09-05 14:19:51 | corona10 | create | |