classification
Title: IDLE: Completion window misplaced when shown above current line
Type: Stage: patch review
Components: IDLE Versions: Python 3.9, Python 3.8, Python 3.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: terry.reedy Nosy List: miss-islington, taleinat, terry.reedy
Priority: normal Keywords: patch

Created on 2019-08-14 06:40 by taleinat, last changed 2019-08-14 17:37 by miss-islington.

Files
File name Uploaded Description Edit
idle_completion_window_position.png taleinat, 2019-08-14 06:46
Pull Requests
URL Status Linked Edit
PR 15267 merged taleinat, 2019-08-14 06:48
PR 15282 merged miss-islington, 2019-08-14 17:06
PR 15283 merged miss-islington, 2019-08-14 17:06
Messages (7)
msg349652 - (view) Author: Tal Einat (taleinat) * (Python committer) Date: 2019-08-14 06:40
When the current line is near the bottom of the shell window, the completions list will be shown above it.  However, instead of appearing directly above the current line, it appears quite a bit higher, about one line too high.  See attached screenshot.

Seen on Windows 10 with current master (2a570af12ac5e4ac5575a68f8739b31c24d01367).

First brought up by Terry Reedy in a comment on PR GH-15169 [1].

[1] https://github.com/python/cpython/pull/15169#issuecomment-521066906
msg349654 - (view) Author: Tal Einat (taleinat) * (Python committer) Date: 2019-08-14 06:49
See PR GH-15267 with a fix.
msg349657 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2019-08-14 07:06
What I reported is that it is too low on my Windows system, with my size and font, mostly covering the line.  Anyway, misplaced before, now perfectly placed.

Now that I see the patch, I seem to remember another place what an update call is needed before gathering window information.

Unless you say differently, I will add idlelib/NEWS.txt item tomorrow and merge.
msg349662 - (view) Author: Tal Einat (taleinat) * (Python committer) Date: 2019-08-14 08:16
> Unless you say differently, I will add idlelib/NEWS.txt item tomorrow and merge.

I've added an idlelib/NEWS.txt entry to the PR.  Feel free to merge.
msg349717 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2019-08-14 17:06
New changeset 71662dc2f12a7e77e5e1dfe64ec87c1b459c3f59 by Terry Jan Reedy (Tal Einat) in branch 'master':
bpo-37849: IDLE: fix completion window positioning above line (GH-15267)
https://github.com/python/cpython/commit/71662dc2f12a7e77e5e1dfe64ec87c1b459c3f59
msg349719 - (view) Author: miss-islington (miss-islington) Date: 2019-08-14 17:24
New changeset 557802dc17498557e481f2ad3d4a83ece469e489 by Miss Islington (bot) in branch '3.8':
bpo-37849: IDLE: fix completion window positioning above line (GH-15267)
https://github.com/python/cpython/commit/557802dc17498557e481f2ad3d4a83ece469e489
msg349722 - (view) Author: miss-islington (miss-islington) Date: 2019-08-14 17:37
New changeset 88cce7b59fa503616295ca1a25bce6251f9cd317 by Miss Islington (bot) in branch '3.7':
bpo-37849: IDLE: fix completion window positioning above line (GH-15267)
https://github.com/python/cpython/commit/88cce7b59fa503616295ca1a25bce6251f9cd317
History
Date User Action Args
2019-08-14 17:37:52miss-islingtonsetmessages: + msg349722
2019-08-14 17:24:07miss-islingtonsetnosy: + miss-islington
messages: + msg349719
2019-08-14 17:06:27miss-islingtonsetpull_requests: + pull_request15007
2019-08-14 17:06:20miss-islingtonsetpull_requests: + pull_request15006
2019-08-14 17:06:16terry.reedysetmessages: + msg349717
2019-08-14 08:16:24taleinatsetmessages: + msg349662
2019-08-14 07:06:28terry.reedysetmessages: + msg349657
2019-08-14 06:52:57taleinatsetpull_requests: - pull_request14989
2019-08-14 06:49:58taleinatsetpull_requests: + pull_request14989
2019-08-14 06:49:04taleinatsetmessages: + msg349654
2019-08-14 06:48:20taleinatsetkeywords: + patch
stage: patch review
pull_requests: + pull_request14988
2019-08-14 06:46:45taleinatsetfiles: + idle_completion_window_position.png
2019-08-14 06:40:49taleinatcreate