classification
Title: Incorporate changes from importlib_metadata 0.19
Type: Stage: resolved
Components: Library (Lib) Versions: Python 3.9, Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: barry, jaraco
Priority: normal Keywords: patch

Created on 2019-07-28 16:14 by jaraco, last changed 2019-07-28 19:46 by jaraco. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 14993 merged jaraco, 2019-07-28 17:39
PR 14995 merged miss-islington, 2019-07-28 18:59
Messages (5)
msg348581 - (view) Author: Jason R. Coombs (jaraco) * (Python committer) Date: 2019-07-28 16:14
Importlib_metadata 0.19 is about to release. Let's sync the code with that milestone (https://gitlab.com/python-devs/importlib_metadata/-/milestones/20).
msg348582 - (view) Author: Jason R. Coombs (jaraco) * (Python committer) Date: 2019-07-28 16:20
I've started work on this in https://github.com/jaraco/cpython/commit/ee913fd4b1cc3bb324f43bfebd4f1006f90c2b6e, but two tests are failing:

======================================================================
FAIL: test_egg_info (test.test_importlib.test_main.DirectoryTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/jaraco/code/public/cpython/Lib/test/test_importlib/test_main.py", line 172, in test_egg_info
    version('unknown-package')
AssertionError: PackageNotFoundError not raised

======================================================================
FAIL: test_zip_version_does_not_match (test.test_importlib.test_zip.TestEgg)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/jaraco/code/public/cpython/Lib/test/test_importlib/test_zip.py", line 29, in test_zip_version_does_not_match
    version('definitely-not-installed')
AssertionError: PackageNotFoundError not raised

----------------------------------------------------------------------
msg348586 - (view) Author: Jason R. Coombs (jaraco) * (Python committer) Date: 2019-07-28 17:38
Okay, I think the issue was that I had failed to `make regen-importlib`. After doing that, the tests are passing. PR incoming.
msg348587 - (view) Author: Jason R. Coombs (jaraco) * (Python committer) Date: 2019-07-28 18:59
New changeset 049460da9c7b5f51732e2966195c44713af9dc4c by Jason R. Coombs in branch 'master':
bpo-37697: Sync with importlib_metadata 0.19 (#14993)
https://github.com/python/cpython/commit/049460da9c7b5f51732e2966195c44713af9dc4c
msg348588 - (view) Author: Jason R. Coombs (jaraco) * (Python committer) Date: 2019-07-28 19:45
New changeset f96334c17946683dd4fb5a84e86a7a4caa4b487d by Jason R. Coombs (Miss Islington (bot)) in branch '3.8':
bpo-37697: Sync with importlib_metadata 0.19 (GH-14993) (GH-14995)
https://github.com/python/cpython/commit/f96334c17946683dd4fb5a84e86a7a4caa4b487d
History
Date User Action Args
2019-07-28 19:46:47jaracosetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2019-07-28 19:45:49jaracosetmessages: + msg348588
2019-07-28 18:59:37miss-islingtonsetpull_requests: + pull_request14761
2019-07-28 18:59:27jaracosetmessages: + msg348587
2019-07-28 17:39:16jaracosetkeywords: + patch
stage: patch review
pull_requests: + pull_request14759
2019-07-28 17:38:16jaracosetmessages: + msg348586
2019-07-28 16:20:59jaracosetmessages: + msg348582
2019-07-28 16:14:59jaracocreate