classification
Title: Change of inheritance of asyncio.CancelledError needs documentation
Type: Stage: resolved
Components: asyncio, Documentation Versions: Python 3.9, Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: asvetlov, docs@python, garyvdm, lisroach, miss-islington, xtreak, yselivanov
Priority: normal Keywords: patch

Created on 2019-07-22 13:36 by garyvdm, last changed 2019-09-11 15:09 by asvetlov. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 15950 merged xtreak, 2019-09-11 13:49
PR 15959 merged miss-islington, 2019-09-11 14:13
Messages (5)
msg348297 - (view) Author: Gary van der Merwe (garyvdm) Date: 2019-07-22 13:36
asyncio.CancelledError inheritance was changed in 3.8. 

https://bugs.python.org/issue32528
https://github.com/python/cpython/commit/431b540bf79f0982559b1b0e420b1b085f667bb7

The documentation still instructs the user to perform a pattern needed before this change. The documentation should probably change to inform them of the change, and to let them know that pattern is only necessary prior to 3.8.
msg351881 - (view) Author: Karthikeyan Singaravelan (xtreak) * (Python triager) Date: 2019-09-11 13:49
Thanks for the report. I think this documentation part is missed in the linked PR. I will prepare a PR that adds the versionchanged directive. Perhaps we can also remove the important section or perhaps just keep the try..except example to ensure users are aware of this. I will prepare a PR for this change.
msg351891 - (view) Author: miss-islington (miss-islington) Date: 2019-09-11 14:12
New changeset 7b69069e9aa0047a0dbe8af1a67aa2b355dc68d8 by Miss Islington (bot) (Xtreak) in branch 'master':
bpo-37651: Document CancelledError is now a subclass of BaseException (GH-15950)
https://github.com/python/cpython/commit/7b69069e9aa0047a0dbe8af1a67aa2b355dc68d8
msg351924 - (view) Author: miss-islington (miss-islington) Date: 2019-09-11 15:08
New changeset e784bb7c6b2a52e80d7c03cb85e5faab11a1ccbd by Miss Islington (bot) in branch '3.8':
bpo-37651: Document CancelledError is now a subclass of BaseException (GH-15950)
https://github.com/python/cpython/commit/e784bb7c6b2a52e80d7c03cb85e5faab11a1ccbd
msg351925 - (view) Author: Andrew Svetlov (asvetlov) * (Python committer) Date: 2019-09-11 15:09
Done, thanks!
History
Date User Action Args
2019-09-11 15:09:17asvetlovsetstatus: open -> closed
resolution: fixed
messages: + msg351925

stage: patch review -> resolved
2019-09-11 15:08:50miss-islingtonsetmessages: + msg351924
2019-09-11 14:13:03miss-islingtonsetpull_requests: + pull_request15594
2019-09-11 14:12:54miss-islingtonsetnosy: + miss-islington
messages: + msg351891
2019-09-11 13:49:43xtreaksetkeywords: + patch
stage: patch review
pull_requests: + pull_request15585
2019-09-11 13:49:34xtreaksetversions: + Python 3.9
nosy: + lisroach, asvetlov, yselivanov, xtreak

messages: + msg351881

components: + asyncio
2019-07-22 13:36:22garyvdmcreate