classification
Title: Fix pure Python implementation of queue
Type: Stage: resolved
Components: Extension Modules, Interpreter Core, Tests Versions: Python 3.9, Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: miss-islington, pablogsal
Priority: normal Keywords: patch

Created on 2019-06-25 01:07 by pablogsal, last changed 2019-06-25 02:14 by miss-islington. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 14351 merged pablogsal, 2019-06-25 01:07
PR 14362 merged miss-islington, 2019-06-25 01:53
Messages (3)
msg346466 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2019-06-25 01:07
The test for the queue module are not testing correctly both the C and the Python implementation of the queue. A consequence is that some errors are being overseed (like the fact that an AttributeError is used instead of an ImportError to catch when importing _queue fails).
msg346474 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2019-06-25 01:53
New changeset 3f5b9088b0ed08e1442cca37df78f609d5cd8c3c by Pablo Galindo in branch 'master':
bpo-37394: Fix pure Python implementation of the queue module (GH-14351)
https://github.com/python/cpython/commit/3f5b9088b0ed08e1442cca37df78f609d5cd8c3c
msg346475 - (view) Author: miss-islington (miss-islington) Date: 2019-06-25 02:14
New changeset 5bf3b89dfb57e705733851ec31131c985feeca62 by Miss Islington (bot) in branch '3.8':
bpo-37394: Fix pure Python implementation of the queue module (GH-14351)
https://github.com/python/cpython/commit/5bf3b89dfb57e705733851ec31131c985feeca62
History
Date User Action Args
2019-06-25 02:14:41miss-islingtonsetnosy: + miss-islington
messages: + msg346475
2019-06-25 01:53:46pablogsalsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2019-06-25 01:53:40miss-islingtonsetpull_requests: + pull_request14179
2019-06-25 01:53:33pablogsalsetmessages: + msg346474
2019-06-25 01:07:48pablogsalsetkeywords: + patch
stage: patch review
pull_requests: + pull_request14175
2019-06-25 01:07:26pablogsalcreate