classification
Title: IDLE: fix Query subclass tab focus traversal order
Type: behavior Stage: resolved
Components: IDLE Versions: Python 3.9, Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: terry.reedy Nosy List: miss-islington, terry.reedy
Priority: normal Keywords: patch

Created on 2019-06-18 02:07 by terry.reedy, last changed 2019-06-18 22:40 by terry.reedy. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 14209 merged terry.reedy, 2019-06-18 20:44
PR 14210 merged miss-islington, 2019-06-18 21:08
PR 14211 merged miss-islington, 2019-06-18 21:10
Messages (4)
msg345940 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2019-06-18 02:07
query.Query creates a popup with entry and ok/cancel buttons, in that order.  Tabbing moves from the entry in that order.  Currently, subclasses that add widgets add them after the 3 above, so they follow Cancel in the tab order.  They do this by overriding create_widgets and initially calling super.create_widgets.

Added widgets should follow the entry box and precede the exit buttons.  To do this, they should be created in between.  Proposed solution: create_widgets calls 'extra_widgets' (pass for Query) after creating the Entry.  Subclasses override to add widgets.
msg346009 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2019-06-18 21:08
New changeset 54cf2e0780ca137dd9abea5d3d974578ce0c18a9 by Terry Jan Reedy in branch 'master':
bpo-37325: Fix focus traversal for 2 IDLE dialogs (#14209)
https://github.com/python/cpython/commit/54cf2e0780ca137dd9abea5d3d974578ce0c18a9
msg346011 - (view) Author: miss-islington (miss-islington) Date: 2019-06-18 21:26
New changeset 44d46e368e6c7cc91fa99a2bfaff544dec7fb04d by Miss Islington (bot) in branch '3.7':
bpo-37325: Fix focus traversal for 2 IDLE dialogs (GH-14209)
https://github.com/python/cpython/commit/44d46e368e6c7cc91fa99a2bfaff544dec7fb04d
msg346012 - (view) Author: miss-islington (miss-islington) Date: 2019-06-18 21:36
New changeset b626b113aee655e273b68eb1edb980f9729c0833 by Miss Islington (bot) in branch '3.8':
bpo-37325: Fix focus traversal for 2 IDLE dialogs (GH-14209)
https://github.com/python/cpython/commit/b626b113aee655e273b68eb1edb980f9729c0833
History
Date User Action Args
2019-06-18 22:40:25terry.reedysetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2019-06-18 21:36:12miss-islingtonsetmessages: + msg346012
2019-06-18 21:26:23miss-islingtonsetnosy: + miss-islington
messages: + msg346011
2019-06-18 21:10:01miss-islingtonsetpull_requests: + pull_request14049
2019-06-18 21:08:40miss-islingtonsetpull_requests: + pull_request14048
2019-06-18 21:08:28terry.reedysetmessages: + msg346009
2019-06-18 20:44:16terry.reedysetkeywords: + patch
stage: test needed -> patch review
pull_requests: + pull_request14047
2019-06-18 02:07:11terry.reedycreate