This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Fix Windows build when --no-tkinter is specified
Type: compile error Stage: resolved
Components: Build, Windows Versions: Python 3.9, Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: steve.dower Nosy List: Paul Monson, miss-islington, paul.moore, steve.dower, tim.golden, zach.ware
Priority: normal Keywords: patch

Created on 2019-06-14 23:36 by Paul Monson, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 14096 merged Paul Monson, 2019-06-14 23:54
PR 14160 merged miss-islington, 2019-06-17 15:22
Messages (5)
msg345648 - (view) Author: Paul Monson (Paul Monson) * Date: 2019-06-14 23:36
https://github.com/python/cpython/pull/14065 breaks building with --no-tkinter. Which breaks the Windows arm32 buildbot

`C:\Users\buildbot\buildarea\3.x.monson-win-arm32.nondebug\build\PCbuild\python.vcxproj(158,9): error MSB4184: The expression "[System.IO.File]::ReadAllText(C:\Users\buildbot\buildarea\3.x.monson-win-arm32.nondebug\build\externals\tcltk-8.6.9.0\arm32\tcllicense.terms)" cannot be evaluated. Could not find a part of the path 'C:\Users\buildbot\buildarea\3.x.monson-win-arm32.nondebug\build\externals\tcltk-8.6.9.0\arm32\tcllicense.terms'.`
msg345649 - (view) Author: Paul Monson (Paul Monson) * Date: 2019-06-14 23:52
Change title: Fix Windows build when --no-tkinter is specified
I noticed this because the Windows arm32 buildbot build was broken.
msg345864 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2019-06-17 15:21
New changeset 00f6493084c385033fe5574314223217d9a26672 by Steve Dower (Paul Monson) in branch 'master':
bpo-37288: Fix Windows build when --no-tkinter is specified (GH-14096)
https://github.com/python/cpython/commit/00f6493084c385033fe5574314223217d9a26672
msg345866 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2019-06-17 15:24
Thanks, Paul!
msg345869 - (view) Author: miss-islington (miss-islington) Date: 2019-06-17 15:48
New changeset 79d8204c4f02d02b3c6570de94c85863c27ddecb by Miss Islington (bot) in branch '3.8':
bpo-37288: Fix Windows build when --no-tkinter is specified (GH-14096)
https://github.com/python/cpython/commit/79d8204c4f02d02b3c6570de94c85863c27ddecb
History
Date User Action Args
2022-04-11 14:59:16adminsetgithub: 81469
2019-06-17 15:48:02miss-islingtonsetnosy: + miss-islington
messages: + msg345869
2019-06-17 15:24:03steve.dowersetstatus: open -> closed
messages: + msg345866

assignee: steve.dower
resolution: fixed
stage: patch review -> resolved
2019-06-17 15:22:20miss-islingtonsetpull_requests: + pull_request14002
2019-06-17 15:21:35steve.dowersetmessages: + msg345864
2019-06-14 23:54:10Paul Monsonsetkeywords: + patch
stage: patch review
pull_requests: + pull_request13951
2019-06-14 23:52:46Paul Monsonsetmessages: + msg345649
title: Windows arm32 buildbot build is broken -> Fix Windows build when --no-tkinter is specified
2019-06-14 23:36:17Paul Monsoncreate