Title: devpoll test failures on Solaris
Type: Stage: patch review
Components: Extension Modules Versions: Python 3.8
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: kulikjak
Priority: normal Keywords: patch

Created on 2019-06-12 14:20 by kulikjak, last changed 2019-06-12 14:21 by kulikjak.

Pull Requests
URL Status Linked Edit
PR 14017 open kulikjak, 2019-06-12 14:21
Messages (1)
msg345365 - (view) Author: Jakub Kulik (kulikjak) * Date: 2019-06-12 14:20
test_devpoll currently ends with two failures with Python 3.8 on Solaris.

First one is wrong number of arguments to devpoll.register function (which thrown the same error as expected in 3.7 but now acts differently).

Second one is that register and modify no longer throw OverflowError when negative number is given as second argument, but rather a ValueError. I am not sure whether this is just a small semantics change or some bigger problem (documentation doesn't mention what error should be thrown).

So I fixed it in attached pull request by changing the expected thrown error but there might be other problem as well.
Date User Action Args
2019-06-12 14:21:52kulikjaksetkeywords: + patch
stage: patch review
pull_requests: + pull_request13882
2019-06-12 14:20:14kulikjakcreate