classification
Title: devpoll test failures on Solaris
Type: Stage: resolved
Components: Extension Modules Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, kulikjak, matrixise
Priority: normal Keywords: patch

Created on 2019-06-12 14:20 by kulikjak, last changed 2019-09-11 14:37 by matrixise. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 14017 merged kulikjak, 2019-06-12 14:21
PR 15948 merged miss-islington, 2019-09-11 13:42
Messages (3)
msg345365 - (view) Author: Jakub Kulik (kulikjak) * Date: 2019-06-12 14:20
test_devpoll currently ends with two failures with Python 3.8 on Solaris.

First one is wrong number of arguments to devpoll.register function (which thrown the same error as expected in 3.7 but now acts differently).

Second one is that register and modify no longer throw OverflowError when negative number is given as second argument, but rather a ValueError. I am not sure whether this is just a small semantics change or some bigger problem (documentation doesn't mention what error should be thrown).

So I fixed it in attached pull request by changing the expected thrown error but there might be other problem as well.
msg351876 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2019-09-11 13:42
New changeset 95da826db9ed4acbc81f32296f14429c06bd2124 by Benjamin Peterson (Jakub Kulík) in branch 'master':
closes bpo-37252: Fix devpoll tests. (GH-14017)
https://github.com/python/cpython/commit/95da826db9ed4acbc81f32296f14429c06bd2124
msg351908 - (view) Author: Stéphane Wirtel (matrixise) * (Python committer) Date: 2019-09-11 14:37
New changeset b4808c1265722b8a03ab436e37c7c337074acb15 by Stéphane Wirtel (Miss Islington (bot)) in branch '3.8':
closes bpo-37252: Fix devpoll tests. (GH-14017) (GH-15948)
https://github.com/python/cpython/commit/b4808c1265722b8a03ab436e37c7c337074acb15
History
Date User Action Args
2019-09-11 14:37:41matrixisesetnosy: + matrixise
messages: + msg351908
2019-09-11 13:42:25miss-islingtonsetpull_requests: + pull_request15583
2019-09-11 13:42:08benjamin.petersonsetstatus: open -> closed

nosy: + benjamin.peterson
messages: + msg351876

resolution: fixed
stage: patch review -> resolved
2019-06-12 14:21:52kulikjaksetkeywords: + patch
stage: patch review
pull_requests: + pull_request13882
2019-06-12 14:20:14kulikjakcreate