classification
Title: Remove expr_text from ast node FormattedValue
Type: behavior Stage: resolved
Components: Interpreter Core Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: eric.smith Nosy List: eric.smith, lukasz.langa, mbussonn
Priority: Keywords: patch

Created on 2019-05-25 20:57 by eric.smith, last changed 2019-05-27 19:32 by eric.smith. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 13597 merged eric.smith, 2019-05-27 18:43
Messages (2)
msg343511 - (view) Author: Eric V. Smith (eric.smith) * (Python committer) Date: 2019-05-25 20:57
I added the expr_text optional field to the FormattedValue node in order to implement the '=' feature of f-strings (see issue 36817).

However, the expr_text field isn't strictly needed. Instead, the same feature could be added with another Constant string node child of the JoinedStr node.

I'm going to remove expr_text and use another Constant in order to remove this change to the 3.8 ast nodes. I have a patch mostly worked out, I'll have it ready in the next day or two. I want to get this in to 3.8 beta 1, because otherwise we're stuck with the expr_text implementation.
msg343677 - (view) Author: Eric V. Smith (eric.smith) * (Python committer) Date: 2019-05-27 19:32
New changeset 6f6ff8a56518a80da406aad6ac8364c046cc7f18 by Eric V. Smith in branch 'master':
bpo-37050: Remove expr_text from FormattedValue ast node, use Constant node instead (GH-13597)
https://github.com/python/cpython/commit/6f6ff8a56518a80da406aad6ac8364c046cc7f18
History
Date User Action Args
2019-05-27 19:32:39eric.smithsetpriority: release blocker ->
status: open -> closed
type: behavior
resolution: fixed
stage: patch review -> resolved
2019-05-27 19:32:07eric.smithsetmessages: + msg343677
2019-05-27 18:43:50eric.smithsetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request13504
2019-05-25 22:15:40mbussonnsetnosy: + mbussonn
2019-05-25 20:57:14eric.smithcreate