➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2019-05-25 20:57 by eric.smith, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 13597 | merged | eric.smith, 2019-05-27 18:43 | |
| Messages (2) | |||
|---|---|---|---|
| msg343511 - (view) | Author: Eric V. Smith (eric.smith) *  |
Date: 2019-05-25 20:57 | |
I added the expr_text optional field to the FormattedValue node in order to implement the '=' feature of f-strings (see issue 36817). However, the expr_text field isn't strictly needed. Instead, the same feature could be added with another Constant string node child of the JoinedStr node. I'm going to remove expr_text and use another Constant in order to remove this change to the 3.8 ast nodes. I have a patch mostly worked out, I'll have it ready in the next day or two. I want to get this in to 3.8 beta 1, because otherwise we're stuck with the expr_text implementation. |
|||
| msg343677 - (view) | Author: Eric V. Smith (eric.smith) * |
Date: 2019-05-27 19:32 | |
New changeset 6f6ff8a56518a80da406aad6ac8364c046cc7f18 by Eric V. Smith in branch 'master': bpo-37050: Remove expr_text from FormattedValue ast node, use Constant node instead (GH-13597) https://github.com/python/cpython/commit/6f6ff8a56518a80da406aad6ac8364c046cc7f18 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:15 | admin | set | github: 81231 |
| 2019-05-27 19:32:39 | eric.smith | set | priority: release blocker -> status: open -> closed type: behavior resolution: fixed stage: patch review -> resolved |
| 2019-05-27 19:32:07 | eric.smith | set | messages: + msg343677 |
| 2019-05-27 18:43:50 | eric.smith | set | keywords:
+ patch stage: needs patch -> patch review pull_requests: + pull_request13504 |
| 2019-05-25 22:15:40 | mbussonn | set | nosy:
+ mbussonn |
| 2019-05-25 20:57:14 | eric.smith | create | |