This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: ast_unparser.c doesn't handle PEP570
Type: Stage: resolved
Components: Interpreter Core Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: pablogsal Nosy List: pablogsal
Priority: normal Keywords: patch

Created on 2019-05-18 22:06 by pablogsal, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 13412 merged pablogsal, 2019-05-18 22:07
Messages (2)
msg342819 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2019-05-18 22:06
Any line in test_annotations() containing positional-only markers
in Lib/test/test_future.py will fail:

        eq('lambda x, /: x')

Run tests sequentially
0:00:00 load avg: 0.71 [1/1] test_future
test test_future failed -- Traceback (most recent call last):
  File "/home/pablogsal/github/cpython/Lib/test/test_future.py", line 186, in test_annotations
    eq("lambda a, /, b, c=True, *vararg, d, e='str', **kwargs: a + b")
  File "/home/pablogsal/github/cpython/Lib/test/test_future.py", line 141, in assertAnnotationEqual
    self.assertEqual(actual, expected)
AssertionError: "lambda b, c=True, *vararg, d, e='str', **kwargs: a + b" != "lambda a, /, b, c=True, *vararg, d, e='str', **kwargs: a + b"
- lambda b, c=True, *vararg, d, e='str', **kwargs: a + b
+ lambda a, /, b, c=True, *vararg, d, e='str', **kwargs: a + b
?        ++++++


test_future failed

== Tests result: FAILURE ==

1 test failed:
    test_future

Total duration: 46 ms
Tests result: FAILURE
msg342822 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2019-05-18 22:40
New changeset da6129e821099c1372d511a11d18af83d6d5d128 by Pablo Galindo in branch 'master':
bpo-36961: Handle positional-only arguments in uparse.c (GH-13412)
https://github.com/python/cpython/commit/da6129e821099c1372d511a11d18af83d6d5d128
History
Date User Action Args
2022-04-11 14:59:15adminsetgithub: 81142
2019-05-18 22:40:37pablogsalsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2019-05-18 22:40:25pablogsalsetmessages: + msg342822
2019-05-18 22:07:14pablogsalsetkeywords: + patch
stage: patch review
pull_requests: + pull_request13323
2019-05-18 22:06:09pablogsalcreate