classification
Title: Remove collections ABCs?
Type: Stage: patch review
Components: Library (Lib) Versions: Python 3.9, Python 3.8
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: eamanu, mbussonn, miss-islington, p-ganssle, rhettinger, serhiy.storchaka, stutzbach, xtreak
Priority: normal Keywords: patch

Created on 2019-05-18 00:52 by p-ganssle, last changed 2019-05-30 21:45 by miss-islington.

Pull Requests
URL Status Linked Edit
PR 13409 merged mbussonn, 2019-05-20 16:31
Messages (4)
msg342779 - (view) Author: Paul Ganssle (p-ganssle) * (Python committer) Date: 2019-05-18 00:52
In PR 5640 (https://github.com/python/cpython/pull/5460), a warning was added that importing ABCs from collections directly is deprecated and will be removed in Python 3.8, but they have not yet been removed and the warning is still active.

If they are going to be removed, presumably it needs to be done before the feature freeze at the end of May, otherwise, in the meantime, I think the warning needs to be updated to say that it will be removed in Python 3.9.
msg342785 - (view) Author: Karthikeyan Singaravelan (xtreak) * (Python triager) Date: 2019-05-18 02:17
Relevant PR and discussion : https://github.com/python/cpython/pull/10596 . pip is incompatible due to the vendored copy of html5lib that needs a new release .
msg342806 - (view) Author: Matthias Bussonnier (mbussonn) * Date: 2019-05-18 17:51
Should it still raise an informative error message with ImportError:

> ImportError: cannot import name 'XXX' from 'collections', please import it from 'collections.abc'.

or just the "cannot import name 'XXXX'" without the  "please import it from 'collections.abc'." ?
msg344005 - (view) Author: miss-islington (miss-islington) Date: 2019-05-30 21:45
New changeset eea47e09394dfb64d3a59a601d947d25bb1bdc96 by Miss Islington (bot) (Matthias Bussonnier) in branch 'master':
bpo-36953: Delay removal of ABCs from collections. (GH-13409)
https://github.com/python/cpython/commit/eea47e09394dfb64d3a59a601d947d25bb1bdc96
History
Date User Action Args
2019-05-30 21:45:51miss-islingtonsetnosy: + miss-islington
messages: + msg344005
2019-05-20 16:31:38mbussonnsetkeywords: + patch
stage: patch review
pull_requests: + pull_request13356
2019-05-18 17:51:30mbussonnsetmessages: + msg342806
2019-05-18 02:17:48xtreaksetnosy: + xtreak
messages: + msg342785
2019-05-18 02:11:57mbussonnsetnosy: + mbussonn
2019-05-18 01:23:49eamanusetnosy: + eamanu
2019-05-18 00:52:44p-gansslecreate