classification
Title: Tools/scripts/setup.py is missing
Type: behavior Stage: resolved
Components: Build Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: berker.peksag, vstinner, xdegaye
Priority: normal Keywords: patch

Created on 2019-04-28 20:24 by xdegaye, last changed 2019-04-29 09:03 by vstinner. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 13003 merged xdegaye, 2019-04-29 08:01
Messages (5)
msg341035 - (view) Author: Xavier de Gaye (xdegaye) * (Python triager) Date: 2019-04-28 20:24
The 'scriptsinstall' Makefile target runs the $(srcdir)/Tools/scripts/setup.py script that does not exist anymore. It has been removed by changeset d3f467ac7441a100eb26412424c2dd96ec3ceb67 (found after running 'cd Tools/scripts/ && git log --diff-filter=D --summary .'). Its content was then:

from distutils.core import setup

if __name__ == '__main__':
    setup(
      scripts=[
        'byteyears.py',
        'checkpyc.py',
        'copytime.py',
        'crlf.py',
        'dutree.py',
        'ftpmirror.py',
        'h2py.py',
        'lfcr.py',
        '../i18n/pygettext.py',
        'logmerge.py',
        '../../Lib/tabnanny.py',
        '../../Lib/timeit.py',
        'untabify.py',
        ],
      )
msg341036 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2019-04-28 20:38
IMO, it would be better if we just remove the scriptsinstall target.
msg341048 - (view) Author: Xavier de Gaye (xdegaye) * (Python triager) Date: 2019-04-29 07:40
Agreed.
msg341056 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-04-29 09:01
New changeset 7a5a1cfe04892351bba8e8d7d21ae2262fa35b67 by Victor Stinner (xdegaye) in branch 'master':
bpo-36747: Remove the stale scriptsinstall Makefile target (GH-13003)
https://github.com/python/cpython/commit/7a5a1cfe04892351bba8e8d7d21ae2262fa35b67
msg341057 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-04-29 09:03
The broken scriptsinstall Makefile target of Python 3.7 doesn't hurt. I suggest to leave it, it's not used by any other target. I prefer to not backport the change just to avoid any risk of regression.

Thanks Xavier for the fix.
History
Date User Action Args
2019-04-29 09:03:29vstinnersetstatus: open -> closed
resolution: fixed
messages: + msg341057

stage: patch review -> resolved
2019-04-29 09:01:48vstinnersetmessages: + msg341056
2019-04-29 08:01:38xdegayesetkeywords: + patch
stage: patch review
pull_requests: + pull_request12924
2019-04-29 07:42:12vstinnersetnosy: + vstinner
2019-04-29 07:40:52xdegayesetmessages: + msg341048
2019-04-28 20:38:51berker.peksagsetnosy: + berker.peksag
messages: + msg341036
2019-04-28 20:24:38xdegayecreate