➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2019-04-24 15:14 by xdegaye, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 14801 | merged | ZackerySpytz, 2019-07-16 18:19 | |
| Messages (3) | |||
|---|---|---|---|
| msg340778 - (view) | Author: Xavier de Gaye (xdegaye) *  |
Date: 2019-04-24 15:14 | |
As reported in issue 16079, the following method is a duplicate: Lib/email/feedparser.py:140 BufferedSubFile.pushlines |
|||
| msg340816 - (view) | Author: Martin Panter (martin.panter) *  |
Date: 2019-04-25 00:30 | |
This is caused by Serhiy’s first change to 2.7 in Issue 21448. Compare Mercurial rev. 1b1f92e39462 (3.4 branch) with ba90bd01c5f1 (2.7). In 2.7, he applied the Python 3 version of the code, which used “str.splitlines” rather than a regular expression “NLCRE_crack.split”. This seems reasonable, but the old Python 2 code remains under a spurious “def pushlines” block. I think that first block of “pushlines” can safely be removed, just leaving the second version, a single line of code like in Python 3. |
|||
| msg351862 - (view) | Author: Benjamin Peterson (benjamin.peterson) * |
Date: 2019-09-11 13:22 | |
New changeset b239ab9107cd5bcbfbfa3b46290191298718ced3 by Benjamin Peterson (Zackery Spytz) in branch '2.7': closes bpo-36711: Remove duplicate method in Lib/email/feedparser.py. (GH-14801) https://github.com/python/cpython/commit/b239ab9107cd5bcbfbfa3b46290191298718ced3 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:14 | admin | set | github: 80892 |
| 2019-09-11 13:22:11 | benjamin.peterson | set | status: open -> closed nosy: + benjamin.peterson messages: + msg351862 resolution: fixed stage: patch review -> resolved |
| 2019-07-16 18:31:39 | ZackerySpytz | set | nosy:
+ ZackerySpytz |
| 2019-07-16 18:19:16 | ZackerySpytz | set | keywords:
+ patch stage: needs patch -> patch review pull_requests: + pull_request14597 |
| 2019-04-25 00:30:11 | martin.panter | set | nosy:
+ barry, r.david.murray, martin.panter messages: + msg340816 components: + email, - Library (Lib) |
| 2019-04-24 15:14:24 | xdegaye | create | |