classification
Title: Comment/PI parsing support for ElementTree
Type: enhancement Stage: resolved
Components: Library (Lib), XML Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: scoder Nosy List: eli.bendersky, scoder, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2019-04-20 07:33 by scoder, last changed 2019-05-01 20:38 by scoder. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 12883 merged scoder, 2019-04-20 08:52
Messages (3)
msg340565 - (view) Author: Stefan Behnel (scoder) * (Python committer) Date: 2019-04-20 07:33
The TreeBuilder in xml.etree.ElementTree ignores comments and processing instructions. It should at least have a way to pass them through, even if there is not currently a way to append comments and PIs to the tree when they appear *outside* of the root element.

The pull parser interface would directly benefit from this, because it can then report "comment" and "pi" events.
msg340566 - (view) Author: Stefan Behnel (scoder) * (Python committer) Date: 2019-04-20 07:35
This is related to issue9521 but not a strict duplicate, because fixing that would require actually adding comments and PIs to the tree when they are not within the root element. When they are, it's in line with the current tree model and this change will do it.
msg341228 - (view) Author: Stefan Behnel (scoder) * (Python committer) Date: 2019-05-01 19:21
New changeset 43851a202cabce1e6be699e7177735c778b6697e by Stefan Behnel in branch 'master':
bpo-36673: Implement comment/PI parsing support for the TreeBuilder in ElementTree. (#12883)
https://github.com/python/cpython/commit/43851a202cabce1e6be699e7177735c778b6697e
History
Date User Action Args
2019-05-01 20:38:32scodersetpull_requests: - pull_request12811
2019-05-01 19:31:14scodersetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2019-05-01 19:21:00scodersetmessages: + msg341228
2019-04-20 11:30:20scodersetpull_requests: + pull_request12811
2019-04-20 08:58:42scodersetnosy: + eli.bendersky, serhiy.storchaka
2019-04-20 08:52:42scodersetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request12808
2019-04-20 07:35:26scodersetmessages: + msg340566
2019-04-20 07:33:22scodercreate