This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Use only public C-API in _xxsubinterpreters module.
Type: Stage: resolved
Components: Interpreter Core Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: eric.snow Nosy List: eric.snow, vstinner
Priority: normal Keywords: patch

Created on 2019-02-23 23:48 by eric.snow, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 12003 merged eric.snow, 2019-02-23 23:55
PR 12359 merged eric.snow, 2019-03-15 22:05
Messages (6)
msg336419 - (view) Author: Eric Snow (eric.snow) * (Python committer) Date: 2019-02-23 23:48
After discussions about our use of the public C-API in stdlib extension modules, I realized that I'd written the _xxsubinterpreters module using internal C-API.  However, there's no reason not to stick to the public C-API.  Fixing this will require adding a few new "private" functions.
msg336973 - (view) Author: Eric Snow (eric.snow) * (Python committer) Date: 2019-03-01 23:50
New changeset bcfa450f210074e16feb761ae5b3e966a2532fcf by Eric Snow in branch 'master':
bpo-36097: Use only public C-API in the_xxsubinterpreters module (adding as necessary). (#12003)
https://github.com/python/cpython/commit/bcfa450f210074e16feb761ae5b3e966a2532fcf
msg337114 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-03-04 13:21
New changeset 4d61e6e3b802399be62a521d6fa785698cb670b5 by Victor Stinner in branch 'master':
Revert: bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall(). (GH-11617) (GH-12159)
https://github.com/python/cpython/commit/4d61e6e3b802399be62a521d6fa785698cb670b5
msg337214 - (view) Author: Eric Snow (eric.snow) * (Python committer) Date: 2019-03-05 15:57
I'll re-merge this once this problem in issue #33608 is resolved.
msg337216 - (view) Author: Eric Snow (eric.snow) * (Python committer) Date: 2019-03-05 16:06
Actually, this is independent of that change.  It had to be reverted because the PR was based on the earlier PR from #33608.  So I may merge this separately...or not, since it would mean having to sort out merge conflicts. :)
msg338042 - (view) Author: Eric Snow (eric.snow) * (Python committer) Date: 2019-03-15 22:35
New changeset c11183cdcff6af13c4339fdcce84ab63f7930ddc by Eric Snow in branch 'master':
bpo-36097: Use only public C-API in the_xxsubinterpreters module (adding as necessary). (gh-12359)
https://github.com/python/cpython/commit/c11183cdcff6af13c4339fdcce84ab63f7930ddc
History
Date User Action Args
2022-04-11 14:59:11adminsetgithub: 80278
2019-03-29 21:09:52eric.snowsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2019-03-15 22:35:52eric.snowsetmessages: + msg338042
2019-03-15 22:05:20eric.snowsetstage: needs patch -> patch review
pull_requests: + pull_request12326
2019-03-05 16:06:32eric.snowsetmessages: + msg337216
stage: needs patch
2019-03-05 15:57:03eric.snowsetstatus: closed -> open
resolution: fixed -> (no value)
messages: + msg337214

stage: resolved -> (no value)
2019-03-04 13:21:31vstinnersetnosy: + vstinner
messages: + msg337114
2019-03-01 23:51:38eric.snowsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2019-03-01 23:50:34eric.snowsetmessages: + msg336973
2019-02-23 23:55:05eric.snowsetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request12034
2019-02-23 23:48:58eric.snowcreate