This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: In WalkTests of test_os.py, sub2_tree missed the dir "SUB21" if symlink can't be supported.
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: pxinwr, zach.ware
Priority: normal Keywords: patch

Created on 2019-02-14 07:32 by pxinwr, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 11853 merged pxinwr, 2019-02-14 08:22
PR 11861 merged miss-islington, 2019-02-15 05:05
Messages (4)
msg335505 - (view) Author: Peixing Xin (pxinwr) * Date: 2019-02-14 07:32
Looking into the setUp method of WalkTests class in test_os.py, sub2_tree missed "SUB21" in its directory list if support.can_symlink() returns False.
msg335582 - (view) Author: miss-islington (miss-islington) Date: 2019-02-15 05:04
New changeset 3e028b2d40370dc986b6f3146a7ae927bc119f97 by Miss Islington (bot) (pxinwr) in branch 'master':
bpo-35994: add sub dir for sub2_tree in os.walk test if symlink is not supported (GH-11853)
https://github.com/python/cpython/commit/3e028b2d40370dc986b6f3146a7ae927bc119f97
msg335583 - (view) Author: miss-islington (miss-islington) Date: 2019-02-15 05:23
New changeset 04a39399ef13197e433757fe13108ad472461094 by Miss Islington (bot) in branch '3.7':
bpo-35994: add sub dir for sub2_tree in os.walk test if symlink is not supported (GH-11853)
https://github.com/python/cpython/commit/04a39399ef13197e433757fe13108ad472461094
msg335585 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2019-02-15 05:24
Thanks for the patch!
History
Date User Action Args
2022-04-11 14:59:11adminsetgithub: 80175
2019-02-15 05:24:59zach.waresetstatus: open -> closed
versions: + Python 3.7
nosy: + zach.ware, - miss-islington
messages: + msg335585

resolution: fixed
stage: patch review -> resolved
2019-02-15 05:23:12miss-islingtonsetmessages: + msg335583
2019-02-15 05:05:09miss-islingtonsetpull_requests: + pull_request11894
2019-02-15 05:04:51miss-islingtonsetnosy: + miss-islington
messages: + msg335582
2019-02-14 08:22:28pxinwrsetkeywords: + patch
stage: patch review
pull_requests: + pull_request11885
2019-02-14 07:32:35pxinwrcreate