➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2019-01-09 09:26 by malin, last changed 2022-04-11 14:59 by admin.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 11473 | closed | malin, 2019-01-09 09:27 | |
| PR 11473 | closed | malin, 2019-01-09 09:27 | |
| PR 11473 | closed | malin, 2019-01-09 09:27 | |
| PR 16146 | merged | hongweipeng, 2019-09-14 17:36 | |
| Messages (5) | |||
|---|---|---|---|
| msg333293 - (view) | Author: Ma Lin (malin) * | Date: 2019-01-09 09:26 | |
static int
long_compare(PyLongObject *a, PyLongObject *b)
{
....
}
This function in /Objects/longobject.c is used to compare two PyLongObject's value.
We only need the sign, converting to -1 or +1 is not necessary.
|
|||
| msg352732 - (view) | Author: Inada Naoki (methane) *  |
Date: 2019-09-18 15:10 | |
New changeset 42acb7b8d29d078bc97b0cfd7c4911b2266b26b9 by Inada Naoki (HongWeipeng) in branch 'master': bpo-35696: Simplify long_compare() (GH-16146) https://github.com/python/cpython/commit/42acb7b8d29d078bc97b0cfd7c4911b2266b26b9 |
|||
| msg352875 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2019-09-20 17:16 | |
I reopen the issue. The win32 job of Azure Pipelines now logs a compiler warning: Objects\longobject.c(412,5): warning C4244: 'function': conversion from 'unsigned long' to 'sdigit', possible loss of data Objects\longobject.c(420,5): warning C4244: 'function': conversion from 'unsigned __int64' to 'sdigit', possible loss of data See also discussion on PR 16146: https://github.com/python/cpython/pull/16146#issuecomment-533351728 |
|||
| msg352883 - (view) | Author: Sergey Fedoseev (sir-sigurd) * | Date: 2019-09-20 19:28 | |
These warnings are caused by https://github.com/python/cpython/commit/c6734ee7c55add5fdc2c821729ed5f67e237a096. I'd fix them, but I'm not sure if we are going to restore CHECK_SMALL_INT() ¯\_(ツ)_/¯ |
|||
| msg352903 - (view) | Author: Ma Lin (malin) * | Date: 2019-09-20 22:26 | |
> I'd fix them, but I'm not sure if we are going to restore CHECK_SMALL_INT() ¯\_(ツ)_/¯ I suggest we slow down, carefully sort out the recent commits for longobject.c: https://bugs.python.org/issue37812#msg352837 Make the code has consistent style, better readability... |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:10 | admin | set | github: 79877 |
| 2019-09-21 09:56:56 | hongweipeng | set | nosy:
+ hongweipeng |
| 2019-09-20 22:26:47 | malin | set | messages: + msg352903 |
| 2019-09-20 19:28:53 | sir-sigurd | set | nosy:
+ sir-sigurd messages: + msg352883 |
| 2019-09-20 17:16:06 | vstinner | set | status: closed -> open nosy: + vstinner messages: + msg352875 keywords: patch, patch, patch resolution: fixed -> |
| 2019-09-18 15:14:29 | methane | set | keywords:
patch, patch, patch status: open -> closed stage: patch review -> resolved resolution: fixed versions: + Python 3.9, - Python 3.8 |
| 2019-09-18 15:10:28 | methane | set | nosy:
+ methane messages: + msg352732 |
| 2019-09-14 17:36:08 | hongweipeng | set | pull_requests: + pull_request15756 |
| 2019-01-09 09:27:45 | malin | set | keywords:
+ patch stage: patch review pull_requests: + pull_request10976 |
| 2019-01-09 09:27:41 | malin | set | keywords:
+ patch stage: (no value) pull_requests: + pull_request10975 |
| 2019-01-09 09:27:33 | malin | set | keywords:
+ patch stage: (no value) pull_requests: + pull_request10974 |
| 2019-01-09 09:26:39 | malin | create | |