classification
Title: Remove the DecodeFSDefault return converter in Argument Clinic
Type: Stage: resolved
Components: Argument Clinic Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: larry, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2018-12-14 09:39 by serhiy.storchaka, last changed 2018-12-17 15:30 by serhiy.storchaka. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 11152 merged serhiy.storchaka, 2018-12-14 09:42
Messages (2)
msg331790 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-12-14 09:39
The DecodeFSDefault return converter is used only in one function, os.ttyname(). It could be used also in os.ctermid(), but in any case there are too small use cases for it, because it is very uncommon to return a bare pointer to static C string. Since it is such uncommon and using this return converter does not add much to readability, I think that it is better to remove it.
msg332006 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-12-17 14:47
New changeset 4db62e115891425db2a974142a72d8eaaf95eecb by Serhiy Storchaka in branch 'master':
bpo-35490: Remove the DecodeFSDefault return converter in AC. (#11152)
https://github.com/python/cpython/commit/4db62e115891425db2a974142a72d8eaaf95eecb
History
Date User Action Args
2018-12-17 15:30:57serhiy.storchakasetstatus: open -> closed
stage: patch review -> resolved
resolution: fixed
versions: + Python 3.8
2018-12-17 14:47:47serhiy.storchakasetmessages: + msg332006
2018-12-14 09:42:32serhiy.storchakasetkeywords: + patch
stage: patch review
pull_requests: + pull_request10381
2018-12-14 09:39:36serhiy.storchakacreate