This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test_flush_return_value fails on FreeBSD
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: berker.peksag Nosy List: berker.peksag, koobs
Priority: normal Keywords: patch

Created on 2018-09-20 15:43 by berker.peksag, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 9451 merged berker.peksag, 2018-09-20 15:56
Messages (3)
msg325890 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2018-09-20 15:43
======================================================================
FAIL: test_flush_return_value (test.test_mmap.MmapTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.x.koobs-freebsd10/build/Lib/test/test_mmap.py", line 754, in test_flush_return_value
    self.assertRaises(OSError, mm.flush, 1, len(b'python'))
AssertionError: OSError not raised by flush

I think I was relying on the behavior of Linux in that assert, it might be better to run that assert only under Linux.
msg325903 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2018-09-20 16:53
New changeset bc854750589d4de0fd55693963964e0558b5c8ac by Berker Peksag in branch 'master':
bpo-34754: Fix test_flush_return_value on FreeBSD (GH-9451)
https://github.com/python/cpython/commit/bc854750589d4de0fd55693963964e0558b5c8ac
msg325916 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2018-09-20 17:44
From AMD64 FreeBSD 10.x Shared 3.x:

> 0:18:38 load avg: 5.04 [390/419/1] test_mmap passed

https://buildbot.python.org/all/#/builders/87/builds/1465/steps/4/logs/stdio
History
Date User Action Args
2022-04-11 14:59:06adminsetgithub: 78935
2018-09-20 17:44:58berker.peksagsetstatus: open -> closed
resolution: fixed
messages: + msg325916

stage: patch review -> resolved
2018-09-20 16:53:11berker.peksagsetmessages: + msg325903
2018-09-20 15:56:34berker.peksagsetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request8866
2018-09-20 15:43:30berker.peksagcreate