This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Get rid of tp_getattro and tp_setattro in pyexpat.xmlparser
Type: enhancement Stage: resolved
Components: Extension Modules Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: eli.bendersky, scoder, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2018-09-19 14:38 by serhiy.storchaka, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 9422 merged serhiy.storchaka, 2018-09-19 14:41
Messages (2)
msg325769 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-09-19 14:38
Currently pyexpat.xmlparser has the tp_getattro and tp_setattro slot for handling some attributes. The proposed PR replaces it with tp_members and tp_getset.

Benefits: constant time access, names of these attributes are added to the result of help(), no need of the __dir__() method, better structured code.
msg328045 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-10-19 15:00
New changeset 55f8249d65af3f1b83df81fa46f6fc6e452ed944 by Serhiy Storchaka in branch 'master':
bpo-34741: Get rid of tp_getattro and tp_setattro in pyexpat.xmlparser. (GH-9422)
https://github.com/python/cpython/commit/55f8249d65af3f1b83df81fa46f6fc6e452ed944
History
Date User Action Args
2022-04-11 14:59:06adminsetgithub: 78922
2018-10-19 15:01:12serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2018-10-19 15:00:57serhiy.storchakasetmessages: + msg328045
2018-09-19 14:41:08serhiy.storchakasetkeywords: + patch
stage: patch review
pull_requests: + pull_request8842
2018-09-19 14:38:57serhiy.storchakacreate