This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Get rid of tp_getattro in ossaudiodev.oss_audio_device
Type: enhancement Stage: resolved
Components: Extension Modules Versions: Python 3.8
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: serhiy.storchaka
Priority: normal Keywords: patch

Created on 2018-09-19 14:31 by serhiy.storchaka, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 9421 merged serhiy.storchaka, 2018-09-19 14:33
Messages (2)
msg325768 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-09-19 14:31
Currently ossaudiodev.oss_audio_device has the tp_getattro slot for handling some attributes. The proposed PR replaces it with tp_members and tp_getset.

Benefits: constant time access, names of these attributes are added to the result of dir() and help(), better structured code.
msg327041 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-10-04 07:42
New changeset 5f5a7781c8bf7bcc476d3e05d980711be3920724 by Serhiy Storchaka in branch 'master':
bpo-34740: Get rid of tp_getattro in ossaudiodev.oss_audio_device. (GH-9421)
Date User Action Args
2022-04-11 14:59:06adminsetgithub: 78921
2018-10-04 07:43:24serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2018-10-04 07:42:10serhiy.storchakasetmessages: + msg327041
2018-09-19 14:33:56serhiy.storchakasetkeywords: + patch
stage: patch review
pull_requests: + pull_request8841
2018-09-19 14:31:29serhiy.storchakacreate