classification
Title: test_shutil fails with busybox unzip
Type: Stage: resolved
Components: Tests Versions: Python 3.8, Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, miss-islington
Priority: normal Keywords: patch

Created on 2018-09-13 16:52 by benjamin.peterson, last changed 2018-09-13 18:47 by miss-islington. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 9262 merged benjamin.peterson, 2018-09-13 16:53
PR 9263 merged miss-islington, 2018-09-13 17:09
PR 9264 merged miss-islington, 2018-09-13 17:09
PR 9266 merged benjamin.peterson, 2018-09-13 17:25
PR 9267 merged benjamin.peterson, 2018-09-13 17:47
PR 9269 merged miss-islington, 2018-09-13 17:57
PR 9270 merged miss-islington, 2018-09-13 17:57
Messages (8)
msg325262 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2018-09-13 16:52
BusyBox has a unzip command, but it doesn't support -t.

======================================================================
FAIL: test_unzip_zipfile (test.test_shutil.TestShutil)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-alpine/build/Lib/test/test_shutil.py", line 1181, in test_unzip_zipfile
    subprocess.check_output(zip_cmd, stderr=subprocess.STDOUT)
subprocess.CalledProcessError: Command '['unzip', '-t', '/tmp/tmp92zs6lmt/archive.zip']' returned non-zero exit status 1.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-alpine/build/Lib/test/test_shutil.py", line 1185, in test_unzip_zipfile
    self.fail(msg.format(exc, details))
AssertionError: Command '['unzip', '-t', '/tmp/tmp92zs6lmt/archive.zip']' returned non-zero exit status 1.
**Unzip Output**
unzip: unrecognized option: t
BusyBox v1.27.2 (2017-12-12 10:41:50 GMT) multi-call binary.
Usage: unzip [-lnopq] FILE[.zip] [FILE]... [-x FILE...] [-d DIR]
Extract FILEs from ZIP archive
	-l	List contents (with -q for short form)
	-n	Never overwrite files (default: ask)
	-o	Overwrite
	-p	Print to stdout
	-q	Quiet
	-x FILE	Exclude FILEs
	-d DIR	Extract into DIR
msg325264 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2018-09-13 17:08
New changeset a710ebd21b09efe902dde84d4862ce5c6427f7af by Benjamin Peterson in branch 'master':
closes bpo-34661: Fix test_shutil if unzip doesn't support -t. (GH-9262)
https://github.com/python/cpython/commit/a710ebd21b09efe902dde84d4862ce5c6427f7af
msg325267 - (view) Author: miss-islington (miss-islington) Date: 2018-09-13 17:27
New changeset 1550b7311216082748ddcdc048ee0374ce004513 by Miss Islington (bot) in branch '3.7':
closes bpo-34661: Fix test_shutil if unzip doesn't support -t. (GH-9262)
https://github.com/python/cpython/commit/1550b7311216082748ddcdc048ee0374ce004513
msg325268 - (view) Author: miss-islington (miss-islington) Date: 2018-09-13 17:32
New changeset 7eeb80b1e0034fd4e6b8d03b2c0fc5c94fe8d8fa by Miss Islington (bot) in branch '3.6':
closes bpo-34661: Fix test_shutil if unzip doesn't support -t. (GH-9262)
https://github.com/python/cpython/commit/7eeb80b1e0034fd4e6b8d03b2c0fc5c94fe8d8fa
msg325270 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2018-09-13 17:57
New changeset e78734d579439861f6d7e12f35d268836b2c1e24 by Benjamin Peterson in branch 'master':
bpo-34661: Fix test skipping call. (GH-9266)
https://github.com/python/cpython/commit/e78734d579439861f6d7e12f35d268836b2c1e24
msg325274 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2018-09-13 18:24
New changeset 18e21883a4ec2a36a02054eb2ff47e3ba9bd1d33 by Benjamin Peterson in branch '2.7':
[2.7] closes bpo-34661: Fix test_shutil if unzip doesn't support -t. (GH-9267)
https://github.com/python/cpython/commit/18e21883a4ec2a36a02054eb2ff47e3ba9bd1d33
msg325277 - (view) Author: miss-islington (miss-islington) Date: 2018-09-13 18:35
New changeset 218b4bf47410ff8ab46b68461267fe10db18aee1 by Miss Islington (bot) in branch '3.7':
bpo-34661: Fix test skipping call. (GH-9266)
https://github.com/python/cpython/commit/218b4bf47410ff8ab46b68461267fe10db18aee1
msg325280 - (view) Author: miss-islington (miss-islington) Date: 2018-09-13 18:47
New changeset 81361cdff847f14f6258c0ead17817d6f9e04022 by Miss Islington (bot) in branch '3.6':
bpo-34661: Fix test skipping call. (GH-9266)
https://github.com/python/cpython/commit/81361cdff847f14f6258c0ead17817d6f9e04022
History
Date User Action Args
2018-09-13 18:47:50miss-islingtonsetmessages: + msg325280
2018-09-13 18:35:25miss-islingtonsetmessages: + msg325277
2018-09-13 18:24:10benjamin.petersonsetmessages: + msg325274
2018-09-13 17:57:43miss-islingtonsetpull_requests: + pull_request8702
2018-09-13 17:57:35miss-islingtonsetpull_requests: + pull_request8701
2018-09-13 17:57:26benjamin.petersonsetmessages: + msg325270
2018-09-13 17:47:27benjamin.petersonsetpull_requests: + pull_request8699
2018-09-13 17:32:48miss-islingtonsetmessages: + msg325268
2018-09-13 17:27:55miss-islingtonsetnosy: + miss-islington
messages: + msg325267
2018-09-13 17:25:11benjamin.petersonsetpull_requests: + pull_request8698
2018-09-13 17:09:16miss-islingtonsetpull_requests: + pull_request8696
2018-09-13 17:09:03miss-islingtonsetpull_requests: + pull_request8695
2018-09-13 17:08:49benjamin.petersonsetstatus: open -> closed
resolution: fixed
messages: + msg325264

stage: patch review -> resolved
2018-09-13 16:53:55benjamin.petersonsetkeywords: + patch
stage: patch review
pull_requests: + pull_request8694
2018-09-13 16:52:18benjamin.petersoncreate