classification
Title: Some tests use hardcoded errno values
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.8, Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: ZackerySpytz, benjamin.peterson
Priority: normal Keywords: patch

Created on 2018-09-06 05:48 by ZackerySpytz, last changed 2018-09-07 16:17 by benjamin.peterson. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 9076 merged ZackerySpytz, 2018-09-06 05:52
PR 9094 merged ZackerySpytz, 2018-09-07 09:30
PR 9096 merged ZackerySpytz, 2018-09-07 09:36
Messages (4)
msg324662 - (view) Author: Zackery Spytz (ZackerySpytz) * (Python triager) Date: 2018-09-06 05:48
test_spwd.py and test_tabnanny.py use hardcoded errno values when they test some exception messages.
msg324709 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2018-09-06 18:43
New changeset b03c2c51909e3b5b5966d86a2829b5ddf2d496aa by Benjamin Peterson (Zackery Spytz) in branch 'master':
closes bpo-34594: Don't hardcode errno values in the tests. (GH-9076)
https://github.com/python/cpython/commit/b03c2c51909e3b5b5966d86a2829b5ddf2d496aa
msg324769 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2018-09-07 16:17
New changeset 9eeecfd5d03cfd6d5cef71de31eed7f65f0e658b by Benjamin Peterson (Zackery Spytz) in branch '3.6':
[3.6] bpo-34594: Don't hardcode errno values in the tests. (GH-9096)
https://github.com/python/cpython/commit/9eeecfd5d03cfd6d5cef71de31eed7f65f0e658b
msg324770 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2018-09-07 16:17
New changeset 18d7dff1bb6f5ca7060b0b2e2a2e74493619178f by Benjamin Peterson (Zackery Spytz) in branch '3.7':
[3.7] bpo-34594: Don't hardcode errno values in the tests. (GH-9094)
https://github.com/python/cpython/commit/18d7dff1bb6f5ca7060b0b2e2a2e74493619178f
History
Date User Action Args
2018-09-07 16:17:36benjamin.petersonsetmessages: + msg324770
2018-09-07 16:17:13benjamin.petersonsetmessages: + msg324769
2018-09-07 09:36:15ZackerySpytzsetpull_requests: + pull_request8551
2018-09-07 09:30:37ZackerySpytzsetpull_requests: + pull_request8550
2018-09-06 18:43:41benjamin.petersonsetstatus: open -> closed

nosy: + benjamin.peterson
messages: + msg324709

resolution: fixed
stage: patch review -> resolved
2018-09-06 05:52:10ZackerySpytzsetkeywords: + patch
stage: patch review
pull_requests: + pull_request8534
2018-09-06 05:48:47ZackerySpytzcreate