classification
Title: test_zipfile gets OverflowError in multiple buildbots
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Dormouse759, pablogsal, petr.viktorin, serhiy.storchaka, vstinner, xtreak
Priority: normal Keywords: patch

Created on 2018-08-02 23:52 by pablogsal, last changed 2018-08-03 23:11 by vstinner. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 8656 merged Dormouse759, 2018-08-03 12:11
Messages (6)
msg322999 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2018-08-02 23:52
test_zipfile gets OverflowError in multiple buildbots:

https://buildbot.python.org/all/#/builders/106/builds/1374
https://buildbot.python.org/all/#/builders/106/builds/1375
https://buildbot.python.org/all/#/builders/106/builds/1376

Example error log:


======================================================================
ERROR: test_add_file_after_2107 (test.test_zipfile.StoredTestsWithSourceFile)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/ssd/buildbot/buildarea/3.x.gps-ubuntu-exynos5-armv7l/build/Lib/test/test_zipfile.py", line 559, in test_add_file_after_2107
    os.utime(TESTFN, (4386268800, 4386268800))
OverflowError: timestamp out of range for platform time_t
----------------------------------------------------------------------
Ran 208 tests in 39.261s
FAILED (errors=1, skipped=1)
1 test failed again:
msg323000 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2018-08-02 23:53
More failures on x86 Gentoo Installed with X 3.x:

https://buildbot.python.org/all/#/builders/103/builds/1240
https://buildbot.python.org/all/#/builders/103/builds/1241
https://buildbot.python.org/all/#/builders/103/builds/1242
msg323022 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-08-03 05:19
This is the result of issue34097.
msg323060 - (view) Author: Petr Viktorin (petr.viktorin) * (Python committer) Date: 2018-08-03 15:59
New changeset 7b41dbad78c6b03ca2f98800a92a1977d3946643 by Petr Viktorin (Marcel Plch) in branch 'master':
bpo-34325: Skip zipfile test for large timestamps when filesystem don't support them. (GH-8656)
https://github.com/python/cpython/commit/7b41dbad78c6b03ca2f98800a92a1977d3946643
msg323094 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-08-03 23:09
The two buildbots are back to green.
msg323096 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-08-03 23:11
A possible enhancement is to mock os.stat() instead of really modifying the real filesystem modification time, it would allow to test the bug on any platform. But I'm not sure that it's worth it, and if anyone is interested, I would suggest to discuss on bpo-34097.
History
Date User Action Args
2018-08-03 23:11:18vstinnersetmessages: + msg323096
2018-08-03 23:09:07vstinnersetstatus: open -> closed

nosy: + vstinner
messages: + msg323094

resolution: fixed
stage: patch review -> resolved
2018-08-03 15:59:23petr.viktorinsetmessages: + msg323060
2018-08-03 12:11:17Dormouse759setkeywords: + patch
stage: patch review
pull_requests: + pull_request8151
2018-08-03 07:00:40petr.viktorinsetnosy: + Dormouse759
2018-08-03 06:59:20petr.viktorinsetnosy: + petr.viktorin
2018-08-03 05:22:38xtreaksetnosy: + xtreak
2018-08-03 05:19:45serhiy.storchakasetnosy: + serhiy.storchaka
messages: + msg323022
2018-08-02 23:53:47pablogsalsetmessages: + msg323000
2018-08-02 23:52:26pablogsalcreate