➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2018-07-28 13:49 by yselivanov, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 8532 | merged | MartinAltmayer, 2018-07-28 15:50 | |
| PR 8586 | merged | miss-islington, 2018-07-31 14:06 | |
| PR 8587 | merged | miss-islington, 2018-07-31 14:07 | |
| Messages (7) | |||
|---|---|---|---|
| msg322561 - (view) | Author: Yury Selivanov (yselivanov) *  |
Date: 2018-07-28 13:49 | |
asyncio documentation has this bit on timeouts:
Timeouts (relative *delay* or absolute *when*) should not exceed one day.
Victor told me that the actual reason for this recommendation is a limitation in epoll (or other OS/selector) that prevents us from waiting for events longer than a day or so.
The solution to this problem is simple: we need to cap the maximum time we pass to the "selector.select()" function (in base_events.py/_run_once) to one day.
|
|||
| msg322572 - (view) | Author: Martin Altmayer (MartinAltmayer) * | Date: 2018-07-28 16:02 | |
Added a small PR. Shall we update the doc? With this PR there is no reason anymore to disallow timeouts greater than one day in asyncio. Greetings from the sprints @ Edinburgh! |
|||
| msg322668 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2018-07-30 11:15 | |
For python 3.7, i suggest to fix the bug but don't remove the note from 3.7 doc, dince 3.7.0 and older have the bug. |
|||
| msg322777 - (view) | Author: Yury Selivanov (yselivanov) * |
Date: 2018-07-31 14:06 | |
New changeset 944451cd8d3e897138f4b43569de13cd081ee251 by Yury Selivanov (MartinAltmayer) in branch 'master': bpo-34263 Cap timeout submitted to epoll/select etc. to one day. (GH-8532) https://github.com/python/cpython/commit/944451cd8d3e897138f4b43569de13cd081ee251 |
|||
| msg322786 - (view) | Author: Yury Selivanov (yselivanov) * |
Date: 2018-07-31 15:29 | |
New changeset 6f16ffc1879fc934eba297b3e81bd940e32a7e03 by Yury Selivanov (Miss Islington (bot)) in branch '3.6': [3.6] bpo-34263 Cap timeout submitted to epoll/select etc. to one day. (GH-8532) (GH-8587) https://github.com/python/cpython/commit/6f16ffc1879fc934eba297b3e81bd940e32a7e03 |
|||
| msg322787 - (view) | Author: Yury Selivanov (yselivanov) * |
Date: 2018-07-31 15:29 | |
New changeset 172a81e42bc30da1bd4027db9cd3b6172469f7fe by Yury Selivanov (Miss Islington (bot)) in branch '3.7': [3.7] bpo-34263 Cap timeout submitted to epoll/select etc. to one day. (GH-8532) (GH-8586) https://github.com/python/cpython/commit/172a81e42bc30da1bd4027db9cd3b6172469f7fe |
|||
| msg322788 - (view) | Author: Yury Selivanov (yselivanov) * |
Date: 2018-07-31 15:32 | |
Merged. Thank you, hope that you'll keep contributing! :) |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:04 | admin | set | github: 78444 |
| 2018-07-31 15:32:43 | yselivanov | set | status: open -> closed resolution: fixed messages: + msg322788 stage: patch review -> resolved |
| 2018-07-31 15:29:11 | yselivanov | set | messages: + msg322787 |
| 2018-07-31 15:29:04 | yselivanov | set | messages: + msg322786 |
| 2018-07-31 14:07:29 | miss-islington | set | pull_requests: + pull_request8096 |
| 2018-07-31 14:06:32 | miss-islington | set | pull_requests: + pull_request8095 |
| 2018-07-31 14:06:20 | yselivanov | set | messages: + msg322777 |
| 2018-07-30 11:15:17 | vstinner | set | messages: + msg322668 |
| 2018-07-28 16:02:43 | MartinAltmayer | set | nosy:
+ MartinAltmayer messages: + msg322572 |
| 2018-07-28 15:50:04 | MartinAltmayer | set | keywords:
+ patch stage: patch review pull_requests: + pull_request8048 |
| 2018-07-28 13:49:09 | yselivanov | create | |