classification
Title: 2to3 munges new lines on Windows
Type: behavior Stage: resolved
Components: Versions: Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: jason.coombs Nosy List: jason.coombs
Priority: high Keywords: 3.7regression, patch

Created on 2018-07-13 12:31 by jason.coombs, last changed 2018-07-13 19:25 by jason.coombs. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 8271 merged jason.coombs, 2018-07-13 12:35
PR 8275 merged miss-islington, 2018-07-13 15:27
Messages (4)
msg321599 - (view) Author: Jason R. Coombs (jason.coombs) * (Python committer) Date: 2018-07-13 12:31
In issue11594, we attempted to solve the newlines issue but inadvertently introduced extraneous CR before CRLF newlines when running on Windows. See https://github.com/python/cpython/pull/6483#issuecomment-401957049 for more details.
msg321615 - (view) Author: Jason R. Coombs (jason.coombs) * (Python committer) Date: 2018-07-13 14:17
The regression never got to 3.6, so this issue likely only affects 3.7+.
msg321619 - (view) Author: Jason R. Coombs (jason.coombs) * (Python committer) Date: 2018-07-13 15:26
New changeset cafaf0447b950fd4f59edd8cbde040c61ae528f8 by Jason R. Coombs in branch 'master':
bpo-34108: Fix double carriage return in 2to3 on Windows (#8271)
https://github.com/python/cpython/commit/cafaf0447b950fd4f59edd8cbde040c61ae528f8
msg321629 - (view) Author: Jason R. Coombs (jason.coombs) * (Python committer) Date: 2018-07-13 19:24
New changeset cf21d0031dd84544d4108765553c2b03dfe726c5 by Jason R. Coombs (Miss Islington (bot)) in branch '3.7':
bpo-34108: Fix double carriage return in 2to3 on Windows (GH-8271) (#8275)
https://github.com/python/cpython/commit/cf21d0031dd84544d4108765553c2b03dfe726c5
History
Date User Action Args
2018-07-13 19:25:33jason.coombssetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2018-07-13 19:24:21jason.coombssetmessages: + msg321629
2018-07-13 15:27:22miss-islingtonsetpull_requests: + pull_request7811
2018-07-13 15:26:06jason.coombssetmessages: + msg321619
2018-07-13 14:17:24jason.coombssetmessages: + msg321615
versions: - Python 3.6
2018-07-13 12:35:37jason.coombssetkeywords: + patch
stage: commit review -> patch review
pull_requests: + pull_request7806
2018-07-13 12:31:21jason.coombscreate