classification
Title: test_multiprocessing_forkserver: test_forkserver_sigkill() fails randomly
Type: Stage: resolved
Components: Tests Versions: Python 3.8, Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: miss-islington, vstinner
Priority: normal Keywords: patch

Created on 2018-07-04 07:49 by vstinner, last changed 2018-07-04 10:35 by vstinner. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 8081 merged vstinner, 2018-07-04 08:11
PR 8084 merged miss-islington, 2018-07-04 09:51
PR 8085 merged miss-islington, 2018-07-04 09:51
Messages (7)
msg321015 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-07-04 07:49
AMD64 FreeBSD 10.x Shared 3.x:
http://buildbot.python.org/all/#/builders/87/builds/1137

======================================================================
FAIL: test_forkserver_sigkill (test.test_multiprocessing_forkserver.WithProcessesTestProcess)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.x.koobs-freebsd10/build/Lib/test/_test_multiprocessing.py", line 680, in test_forkserver_sigkill
    self.check_forkserver_death(signal.SIGKILL)
  File "/usr/home/buildbot/python/3.x.koobs-freebsd10/build/Lib/test/_test_multiprocessing.py", line 670, in check_forkserver_death
    self.assertTrue(evt.is_set())
AssertionError: False is not true

Re-running test 'test_multiprocessing_forkserver' in verbose mode
Ran 310 tests in 100.124s
OK (skipped=27)
msg321017 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-07-04 07:50
Another example of failure:
https://bugs.python.org/issue31687#msg307355

x86 Tiger 3.x:

http://buildbot.python.org/all/#/builders/30/builds/260

======================================================================
FAIL: test_semaphore_tracker (test.test_multiprocessing_forkserver.TestSemaphoreTracker)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/db3l/buildarea/3.x.bolen-tiger/build/Lib/test/_test_multiprocessing.py", line 4380, in test_semaphore_tracker
    _multiprocessing.sem_unlink(name2)
AssertionError: OSError not raised

======================================================================
FAIL: test_forkserver_sigkill (test.test_multiprocessing_forkserver.WithProcessesTestProcess)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/db3l/buildarea/3.x.bolen-tiger/build/Lib/test/_test_multiprocessing.py", line 653, in test_forkserver_sigkill
    self.check_forkserver_death(signal.SIGKILL)
  File "/Users/db3l/buildarea/3.x.bolen-tiger/build/Lib/test/_test_multiprocessing.py", line 643, in check_forkserver_death
    self.assertTrue(evt.is_set())
AssertionError: False is not true
msg321024 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-07-04 09:49
New changeset 07888e1cce89e9bb7dc501e287b4cb126e01c378 by Victor Stinner in branch 'master':
bpo-34040, multiprocessing: Fix test_forkserver_sigkill() (GH-8081)
https://github.com/python/cpython/commit/07888e1cce89e9bb7dc501e287b4cb126e01c378
msg321025 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-07-04 09:54
Python 2.7 is not affected: it has no forkserver.
msg321028 - (view) Author: miss-islington (miss-islington) Date: 2018-07-04 10:10
New changeset eb700f8c94602feb8c10ad8fc600f55e17e3b092 by Miss Islington (bot) in branch '3.7':
bpo-34040, multiprocessing: Fix test_forkserver_sigkill() (GH-8081)
https://github.com/python/cpython/commit/eb700f8c94602feb8c10ad8fc600f55e17e3b092
msg321030 - (view) Author: miss-islington (miss-islington) Date: 2018-07-04 10:15
New changeset ae23d8de8d7d810a8dbe1b09ea37590aff3e1aa0 by Miss Islington (bot) in branch '3.6':
bpo-34040, multiprocessing: Fix test_forkserver_sigkill() (GH-8081)
https://github.com/python/cpython/commit/ae23d8de8d7d810a8dbe1b09ea37590aff3e1aa0
msg321031 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-07-04 10:35
I doubled the sleep: it should be better. If not, we can easily increase even more the sleep ;-)
History
Date User Action Args
2018-07-04 10:35:04vstinnersetstatus: open -> closed
resolution: fixed
messages: + msg321031

stage: patch review -> resolved
2018-07-04 10:15:18miss-islingtonsetmessages: + msg321030
2018-07-04 10:10:17miss-islingtonsetnosy: + miss-islington
messages: + msg321028
2018-07-04 09:54:38vstinnersetmessages: + msg321025
2018-07-04 09:51:53miss-islingtonsetpull_requests: + pull_request7686
2018-07-04 09:51:11miss-islingtonsetpull_requests: + pull_request7685
2018-07-04 09:49:51vstinnersetmessages: + msg321024
2018-07-04 08:11:54vstinnersetkeywords: + patch
stage: patch review
pull_requests: + pull_request7682
2018-07-04 07:50:22vstinnersetmessages: + msg321017
2018-07-04 07:49:19vstinnercreate