classification
Title: IDLE macosx: add tests.
Type: enhancement Stage: needs patch
Components: IDLE Versions: Python 3.8, Python 3.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: terry.reedy Nosy List: markroseman, ned.deily, terry.reedy
Priority: normal Keywords:

Created on 2018-06-26 03:50 by terry.reedy, last changed 2018-12-12 02:34 by terry.reedy.

Messages (4)
msg320468 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-26 03:50
For overrideRootMenu, move nested functions to module level.
Try to move 3 imports to module level.  Test startup on mac.
Mock 'window' with mock functions.
msg320469 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-26 04:01
Ned, I would like to rename at least some of the functions in idlelib.macosx.  For instance, function overrideRootMenu to override_root_menu.  Would this affect any of the installation adjustments?  IE, does the installer import the module for whatever reason?

Also, do the windowing types on currently supported machines still include all of Xquartz, Cocoa, Carbon (both Aqua), and other?  Is the windowing type determined by the hardware, or by the macOS version?
msg320471 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2018-06-26 05:39
> Would this affect any of the installation adjustments?

I don't think so but there's one way to be sure :)  If you merge your changes to master, we can doublecheck before backporting them.

> Is the windowing type determined by the hardware, or by the macOS version?

The windowing type is determined by the variant of Tk that tkinter is dynamically linking with.  While Cocoa Tk is now the most common, it is still possible to run into the other variants; for example, MacPorts supports building an X11 (Xquartz) variant of Tk 8.6 along with a Cocoa one.  If support for the various window types isn't causing a maintenance burden, it would be nice to retain them.
msg320671 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-28 15:43
Mark Roseman emailed me that moving the 3 imports within overrideRootMenu to the top of the module does not appear to cause a problem.
History
Date User Action Args
2018-12-12 02:34:48terry.reedysetversions: - Python 3.6
2018-06-28 22:18:47markrosemansetnosy: + markroseman

components: + IDLE
assignee: terry.reedy
2018-06-28 15:43:51terry.reedysetmessages: + msg320671
2018-06-26 05:39:07ned.deilysetmessages: + msg320471
2018-06-26 04:02:19terry.reedylinkissue33964 dependencies
2018-06-26 04:01:46terry.reedysetnosy: + ned.deily
messages: + msg320469
2018-06-26 03:50:48terry.reedysettitle: IDLE macosc: add tests. -> IDLE macosx: add tests.
2018-06-26 03:50:35terry.reedycreate