Title: IDLE maxosc.overrideRootMenu: remove unused menudict
Type: performance Stage: patch review
Components: IDLE Versions: Python 3.8, Python 3.7
Status: open Resolution:
Dependencies: 33963 Superseder:
Assigned To: terry.reedy Nosy List: cheryl.sabella, terry.reedy
Priority: normal Keywords: patch

Created on 2018-06-26 04:01 by terry.reedy, last changed 2019-03-20 19:52 by cheryl.sabella.

Pull Requests
URL Status Linked Edit
PR 7926 open terry.reedy, 2018-06-26 04:08
Messages (2)
msg320470 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-26 04:01
Function local name 'menudict' is initialized empty, two key value pairs are added, and it is never touched again.
msg338509 - (view) Author: Cheryl Sabella (cheryl.sabella) * (Python committer) Date: 2019-03-20 19:52
Since there's a `self.menudict` in the editor, I wonder if this was intended for that.  The `self.menudict` is used in `ApplyKeyBindings`, which is called when the key bindings change in configdialog.  So, if the mac OS menu isn't added to `self.menudict`, does that mean that the Mac key bindings aren't updated?
Date User Action Args
2019-03-20 19:52:30cheryl.sabellasetnosy: + cheryl.sabella
messages: + msg338509
2019-03-20 16:37:35terry.reedysetassignee: terry.reedy
components: + IDLE
versions: - Python 3.6
2018-06-26 04:08:03terry.reedysetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request7534
2018-06-26 04:02:19terry.reedysetdependencies: + IDLE macosx: add tests.
2018-06-26 04:01:56terry.reedycreate