This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Unused variable in pure embedding example
Type: enhancement Stage: resolved
Components: Documentation Versions: Python 3.8, Python 3.7, Python 3.6, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: Philip Kendall, docs@python, emilyemorehouse, methane, miss-islington
Priority: normal Keywords: patch

Created on 2018-06-25 19:56 by Philip Kendall, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 7927 merged thatiparthy, 2018-06-26 04:51
PR 7982 merged miss-islington, 2018-06-28 06:25
PR 7983 merged miss-islington, 2018-06-28 06:26
PR 7984 merged miss-islington, 2018-06-28 06:27
Messages (7)
msg320436 - (view) Author: Philip Kendall (Philip Kendall) Date: 2018-06-25 19:56
Line 6 of the "Pure Embedding" example at https://docs.python.org/3/extending/embedding.html#pure-embedding :

PyObject *pName, *pModule, *pDict, *pFunc;

contains the pDict variable which is not used anywhere else in the code, giving a compiler warning. Simple fix: just remove pDict from the list of variables.

I can make a PR if you need one.
msg320442 - (view) Author: Emily Morehouse (emilyemorehouse) * (Python committer) Date: 2018-06-25 21:13
Thanks, Philip! If you're interested in submitting a PR, please do! If not, just comment back so someone else can pick it up.
msg320480 - (view) Author: Philip Kendall (Philip Kendall) Date: 2018-06-26 08:16
Thanks thatiparthy :-)
msg320648 - (view) Author: Inada Naoki (methane) * (Python committer) Date: 2018-06-28 06:31
thanks
msg320649 - (view) Author: miss-islington (miss-islington) Date: 2018-06-28 06:37
New changeset bcb1ac82656fac22b12df387a5c6f4b10b7eefef by Miss Islington (bot) in branch '2.7':
bpo-33958: Doc: Remove unused variable in example (GH-7927)
https://github.com/python/cpython/commit/bcb1ac82656fac22b12df387a5c6f4b10b7eefef
msg320650 - (view) Author: miss-islington (miss-islington) Date: 2018-06-28 06:41
New changeset 702d43cab6ae05751b357dd2e7b7fac1a594113a by Miss Islington (bot) in branch '3.7':
bpo-33958: Doc: Remove unused variable in example (GH-7927)
https://github.com/python/cpython/commit/702d43cab6ae05751b357dd2e7b7fac1a594113a
msg320651 - (view) Author: miss-islington (miss-islington) Date: 2018-06-28 06:45
New changeset ff41cc7dee7fb2ab2ac39915a7ec6eb8808e6a1c by Miss Islington (bot) in branch '3.6':
bpo-33958: Doc: Remove unused variable in example (GH-7927)
https://github.com/python/cpython/commit/ff41cc7dee7fb2ab2ac39915a7ec6eb8808e6a1c
History
Date User Action Args
2022-04-11 14:59:02adminsetgithub: 78139
2018-06-28 06:45:31miss-islingtonsetmessages: + msg320651
2018-06-28 06:41:31miss-islingtonsetmessages: + msg320650
2018-06-28 06:37:21miss-islingtonsetnosy: + miss-islington
messages: + msg320649
2018-06-28 06:31:48methanesetstatus: open -> closed

nosy: + methane
messages: + msg320648

resolution: fixed
stage: patch review -> resolved
2018-06-28 06:27:32miss-islingtonsetpull_requests: + pull_request7595
2018-06-28 06:26:31miss-islingtonsetpull_requests: + pull_request7594
2018-06-28 06:25:47miss-islingtonsetpull_requests: + pull_request7593
2018-06-28 06:24:39methanesetversions: + Python 2.7, Python 3.7, Python 3.8
2018-06-26 08:16:55Philip Kendallsetmessages: + msg320480
title: Unused variable in pur embedding example -> Unused variable in pure embedding example
2018-06-26 04:51:38thatiparthysetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request7535
2018-06-25 21:13:39emilyemorehousesetnosy: + emilyemorehouse

messages: + msg320442
stage: needs patch
2018-06-25 19:56:29Philip Kendallcreate