This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Minor improvements of tests for os.path.
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.8, Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: miss-islington, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2018-06-14 16:59 by serhiy.storchaka, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 7715 merged serhiy.storchaka, 2018-06-15 18:41
PR 7751 merged miss-islington, 2018-06-16 10:27
PR 7752 merged miss-islington, 2018-06-16 10:28
Messages (4)
msg319529 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-06-14 16:59
When working on a path for issue33721 I have found that some tests for os.path can be improved, and these changes are worth backporting to older versions (3.6+).

* Test exists(), lexists(), isdir(), isfile(), islink(), ismount() with bytes paths.
* Remove unneeded silencing DeprecationWarning for ismount() with bytes path.
* Test common functions with unencodable and undecodable paths.
* Minor clean up and refactoring.
msg319730 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-06-16 10:26
New changeset 17a0088e2680e12ce2c5f2ffc6b71766299e38d5 by Serhiy Storchaka in branch 'master':
bpo-33861: Minor improvements of tests for os.path. (GH-7715)
https://github.com/python/cpython/commit/17a0088e2680e12ce2c5f2ffc6b71766299e38d5
msg319731 - (view) Author: miss-islington (miss-islington) Date: 2018-06-16 10:57
New changeset 633593372a8aec46644a39e8d0b68e0f1eb5ed38 by Miss Islington (bot) in branch '3.7':
bpo-33861: Minor improvements of tests for os.path. (GH-7715)
https://github.com/python/cpython/commit/633593372a8aec46644a39e8d0b68e0f1eb5ed38
msg319732 - (view) Author: miss-islington (miss-islington) Date: 2018-06-16 10:58
New changeset 5c23e21ef655db35af45ed98a62eb54bff64dbd0 by Miss Islington (bot) in branch '3.6':
bpo-33861: Minor improvements of tests for os.path. (GH-7715)
https://github.com/python/cpython/commit/5c23e21ef655db35af45ed98a62eb54bff64dbd0
History
Date User Action Args
2022-04-11 14:59:01adminsetgithub: 78042
2018-06-16 11:04:58serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2018-06-16 10:58:12miss-islingtonsetmessages: + msg319732
2018-06-16 10:57:52miss-islingtonsetnosy: + miss-islington
messages: + msg319731
2018-06-16 10:28:05miss-islingtonsetpull_requests: + pull_request7360
2018-06-16 10:27:21miss-islingtonsetpull_requests: + pull_request7359
2018-06-16 10:26:02serhiy.storchakasetmessages: + msg319730
2018-06-15 18:41:08serhiy.storchakasetkeywords: + patch
stage: patch review
pull_requests: + pull_request7330
2018-06-14 16:59:32serhiy.storchakacreate