classification
Title: Cleanup start_tls() implementation
Type: enhancement Stage: resolved
Components: asyncio Versions: Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: yselivanov Nosy List: asvetlov, yselivanov
Priority: normal Keywords: patch

Created on 2018-06-04 17:45 by yselivanov, last changed 2018-06-05 14:18 by yselivanov. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 7403 merged yselivanov, 2018-06-04 17:47
PR 7428 merged miss-islington, 2018-06-05 13:03
Messages (3)
msg318688 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2018-06-04 17:45
Current start_tls() implementation might raise an incorrect error message.  It should also consistently cancel callbacks that it schedules in case of unhandled error.
msg318750 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2018-06-05 13:00
New changeset 415bc46a78e785f357c8960ae70f18a6b6cccbb6 by Yury Selivanov in branch 'master':
bpo-33769: start_tls: Fix error message; cancel callbacks on error (GH-7403)
https://github.com/python/cpython/commit/415bc46a78e785f357c8960ae70f18a6b6cccbb6
msg318760 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2018-06-05 14:18
New changeset 79c7e57c46a9e5ae2b99a821e152f334b775df2d by Yury Selivanov (Miss Islington (bot)) in branch '3.7':
bpo-33769: start_tls: Fix error message; cancel callbacks on error (GH-7403) (GH-7428)
https://github.com/python/cpython/commit/79c7e57c46a9e5ae2b99a821e152f334b775df2d
History
Date User Action Args
2018-06-05 14:18:43yselivanovsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2018-06-05 14:18:23yselivanovsetmessages: + msg318760
2018-06-05 13:03:52miss-islingtonsetpull_requests: + pull_request7054
2018-06-05 13:00:00yselivanovsetmessages: + msg318750
2018-06-04 17:47:43yselivanovsetkeywords: + patch
stage: patch review
pull_requests: + pull_request7030
2018-06-04 17:45:55yselivanovcreate