classification
Title: Leaked files in test_io
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.8, Python 3.7, Python 3.6, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: ned.deily, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2018-06-03 16:12 by serhiy.storchaka, last changed 2018-06-04 05:16 by serhiy.storchaka. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 7361 merged serhiy.storchaka, 2018-06-03 18:12
PR 7370 merged miss-islington, 2018-06-04 02:55
PR 7372 merged miss-islington, 2018-06-04 03:00
PR 7373 merged serhiy.storchaka, 2018-06-04 03:04
Messages (5)
msg318567 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-06-03 16:12
$ ./python -m test -v -m test.test_io.CBufferedReaderTest.test_garbage_collection test_io
...
Warning -- files was modified by test_io
  Before: []
  After:  ['@test_18627_tmp'] 
test_io failed (env changed)


$ ./python -m test -v -m test.test_io.CBufferedWriterTest.test_garbage_collection test_io
...
Warning -- files was modified by test_io
  Before: []
  After:  ['@test_18654_tmp'] 
test_io failed (env changed)


$ ./python -m test -v -m test.test_io.CBufferedWriterTest.test_truncate test_io
...
Warning -- files was modified by test_io
  Before: []
  After:  ['@test_18663_tmp'] 
test_io failed (env changed)


$ ./python -m test -v -m test.test_io.CBufferedWriterTest.test_truncate_after_write test_io
...
Warning -- files was modified by test_io
  Before: []
  After:  ['@test_18666_tmp'] 
test_io failed (env changed)


And the same for PyBufferedWriterTest, CBufferedRandomTest and PyBufferedRandomTest.
msg318604 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2018-06-04 02:54
New changeset e36837cb71032ccfa713e75623b314f091dc22bb by Ned Deily (Serhiy Storchaka) in branch 'master':
bpo-33760: Fix file leaks in test_io. (GH-7361)
https://github.com/python/cpython/commit/e36837cb71032ccfa713e75623b314f091dc22bb
msg318608 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2018-06-04 03:15
New changeset 4d11fe7cad9e138423e16338c88908f24a55f1cf by Ned Deily (Miss Islington (bot)) in branch '3.7':
bpo-33760: Fix file leaks in test_io. (GH-7361) (GH-7370)
https://github.com/python/cpython/commit/4d11fe7cad9e138423e16338c88908f24a55f1cf
msg318610 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2018-06-04 03:31
New changeset d18b13d36a22f93050a9d7cdfce594002f69236f by Ned Deily (Miss Islington (bot)) in branch '3.6':
bpo-33760: Fix file leaks in test_io. (GH-7361) (GH-7372)
https://github.com/python/cpython/commit/d18b13d36a22f93050a9d7cdfce594002f69236f
msg318612 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2018-06-04 03:37
New changeset b02ceb57d23c26aca6666b3a9f4c5b7d84d0ea0a by Ned Deily (Serhiy Storchaka) in branch '2.7':
[2.7] bpo-33760: Fix file leaks in test_io. (GH-7361). (GH-7373)
https://github.com/python/cpython/commit/b02ceb57d23c26aca6666b3a9f4c5b7d84d0ea0a
History
Date User Action Args
2018-06-04 05:16:53serhiy.storchakasetstatus: open -> closed
type: behavior
resolution: fixed
stage: patch review -> resolved
2018-06-04 03:37:59ned.deilysetmessages: + msg318612
2018-06-04 03:31:53ned.deilysetmessages: + msg318610
2018-06-04 03:15:13ned.deilysetmessages: + msg318608
2018-06-04 03:04:31serhiy.storchakasetpull_requests: + pull_request7000
2018-06-04 03:00:13miss-islingtonsetpull_requests: + pull_request6999
2018-06-04 02:55:24miss-islingtonsetstage: patch review
pull_requests: + pull_request6997
2018-06-04 02:54:00ned.deilysetnosy: + ned.deily
messages: + msg318604
2018-06-03 18:12:40serhiy.storchakasetstage: patch review -> (no value)
components: + Tests
versions: + Python 2.7, Python 3.6, Python 3.7, Python 3.8
2018-06-03 18:12:07serhiy.storchakasetkeywords: + patch
stage: patch review
pull_requests: + pull_request6988
2018-06-03 16:12:46serhiy.storchakacreate